Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added two new metrics for vcenter receiver #37253

Merged
merged 1 commit into from
Jan 18, 2025
Merged

Added two new metrics for vcenter receiver #37253

merged 1 commit into from
Jan 18, 2025
+288 −0

Conversation

samiura
Copy link
Contributor

@samiura samiura commented Jan 15, 2025 •
edited
Loading

Description

This PR adds the vcenter.vm.memory.granted and vcenter.host.cpu.capacity metric.
More information on this metric can be found here.

#37257

Testing

The metric was scraped from a test vCenter environment, and golden test files were updated to reflect the addition of the metric.

Documentation

Documentation was updated according to the metadata.yaml

Screenshot 2025-01-14 at 10 48 02 AM Screenshot 2025-01-15 at 11 35 31 AM

@samiura samiura force-pushed the add-two-new-vecenter-receiver-metrics branch from 3f669bc to a848f1d Compare January 15, 2025 19:22
@samiura samiura marked this pull request as ready for review January 15, 2025 19:51
@samiura samiura requested a review from a team as a code owner January 15, 2025 19:51
@samiura samiura requested a review from ChrsMark January 15, 2025 19:51
@samiura
Copy link
Contributor Author

samiura commented Jan 15, 2025

Do I need to create an issue for this? Per this link, it does not seem like one is warranted for this particular enhancement.

@schmikei
Copy link
Contributor

schmikei commented Jan 15, 2025 •
edited
Loading

Do I need to create an issue for this? Per this link, it does not seem like one is warranted for this particular enhancement.

I think it would be good to create an issue so that it can be triaged before accepted. https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/7fd70545b1ca223f8e1b21e9d45cb1d1df3a6e36/issue-triaging.md

Let me know if you need help creating the issue, but I would describe this as a good issue to emulate. It helps keep the changelog clean and gives people a place to triage/discuss the feature!

#33607

@samiura
Copy link
Contributor Author

samiura commented Jan 15, 2025 •
edited
Loading

Do I need to create an issue for this? Per this link, it does not seem like one is warranted for this particular enhancement.

I think it would be good to create an issue so that it can be triaged before accepted. https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/7fd70545b1ca223f8e1b21e9d45cb1d1df3a6e36/issue-triaging.md

Let me know if you need help creating the issue, but I would describe this as a good issue to emulate. It helps keep the changelog clean and gives people a place to triage/discuss the feature!

#33607

@schmikei Created #37257

@samiura samiura force-pushed the add-two-new-vecenter-receiver-metrics branch 2 times, most recently from 53bf317 to dc605a5 Compare January 15, 2025 22:49
@samiura samiura mentioned this pull request Jan 15, 2025
Closed
@samiura samiura force-pushed the add-two-new-vecenter-receiver-metrics branch 7 times, most recently from 5e081d1 to 185c3fe Compare January 17, 2025 01:18
atoulme
atoulme approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@atoulme atoulme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me. Codeowners should review.

@samiura
Copy link
Contributor Author

samiura commented Jan 17, 2025

Changes look good to me. Codeowners should review.

Thanks @atoulme

schmikei
schmikei approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@schmikei schmikei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as a codeowner this looks good to me, thank you for your contribution 🚀

@samiura samiura force-pushed the add-two-new-vecenter-receiver-metrics branch from 6e2f960 to 2397c3e Compare January 17, 2025 20:12
@samiura @atoulme
Added two new metrics for vcenter receiver
f2692b5 
Signed-off-by: Samiur Arif <[email protected]>

Update receiver/vcenterreceiver/metadata.yaml

Co-authored-by: Antoine Toulme <[email protected]>
@samiura samiura force-pushed the add-two-new-vecenter-receiver-metrics branch from 2397c3e to f2692b5 Compare January 17, 2025 20:16
@atoulme atoulme added the ready to merge Code review completed; ready to merge by maintainers label Jan 17, 2025
@songy23 songy23 merged commit 5412666 into open-telemetry:main Jan 18, 2025
174 of 175 checks passed
@github-actions github-actions bot added this to the next release milestone Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chan-tim-sumo chan-tim-sumo chan-tim-sumo approved these changes

@schmikei schmikei schmikei approved these changes

@atoulme atoulme atoulme approved these changes

@StefanKurek StefanKurek Awaiting requested review from StefanKurek

@ChrsMark ChrsMark Awaiting requested review from ChrsMark ChrsMark is a code owner automatically assigned from open-telemetry/collector-contrib-approvers

Assignees

@jpkrohling jpkrohling

Labels
ready to merge Code review completed; ready to merge by maintainers receiver/vcenter
Projects
None yet
Milestone
next release
Development

Successfully merging this pull request may close these issues.
6 participants
@samiura @schmikei @atoulme @chan-tim-sumo @jpkrohling @songy23