Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[elasticsearchexporter] support compression level #37260

Merged
merged 11 commits into from
Feb 17, 2025

Conversation

khushijain21
Copy link
Contributor

@khushijain21 khushijain21 commented Jan 16, 2025

Description

This PR syncs support for configuring compression level on ES exporter. Compression Level is a supported param on confighttp. Ref https://github.com/open-telemetry/opentelemetry-collector/blob/main/config/configcompression/compressiontype.go#L16-L18

Testing

Added UT

Documentation

The documentation is also updated with default level in case no level is provided

@khushijain21 khushijain21 requested a review from a team as a code owner January 16, 2025 05:17
@khushijain21 khushijain21 marked this pull request as draft January 16, 2025 05:17
@khushijain21 khushijain21 changed the title support compression level [elasticsearchexporter] support compression level Jan 16, 2025
Copy link
Contributor

@carsonip carsonip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, looking forward to collector support.

Copy link
Contributor

github-actions bot commented Feb 4, 2025

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Feb 4, 2025
@khushijain21 khushijain21 marked this pull request as ready for review February 11, 2025 09:56
@khushijain21
Copy link
Contributor Author

khushijain21 commented Feb 11, 2025

the changelog entry is added but the pipleline does not recognize it

@khushijain21
Copy link
Contributor Author

can we merge this? The pipeline does not seem to be failing for related changes

Copy link
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase / merge main

@andrzej-stencel andrzej-stencel merged commit 69ac9ea into open-telemetry:main Feb 17, 2025
162 checks passed
@github-actions github-actions bot added this to the next release milestone Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants