-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[processor/transform] Replace ParserCollection and add initial support for context inference #37272
Merged
evan-bradley
merged 3 commits into
open-telemetry:main
from
edmocosta:replace-pc-and-add-intial-contextinference-support
Jan 22, 2025
Merged
[processor/transform] Replace ParserCollection and add initial support for context inference #37272
evan-bradley
merged 3 commits into
open-telemetry:main
from
edmocosta:replace-pc-and-add-intial-contextinference-support
Jan 22, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs a changelog and if we can make it so that the existing user's use of cache
is unaffected that I believe it can be an enhancement instead of breaking.
TylerHelmuth
approved these changes
Jan 17, 2025
@evan-bradley please review. I'll merge on Friday unless there are objections or you merge it first. |
evan-bradley
approved these changes
Jan 22, 2025
chengchuanpeng
pushed a commit
to chengchuanpeng/opentelemetry-collector-contrib
that referenced
this pull request
Jan 26, 2025
…t for context inference (open-telemetry#37272)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is part of #29017, and a split from #36888. It changes the
transformprocessor
, adding the initial support for expressing statement's context via path names.Change log:
context
configuration key is set (current mode), it relies on the parser collection and statements rewrite utility to prepend the configured context value on the statements paths, making it backward compatible and not requiring users to change their existing configurations.context
configuration key is empty, it requires all statements's paths to have a valid context prefix, and relies on the context inferrer utility to choose the right parser.TransformContext
.collector/consumer
interfaces are not implemented anymore.Examples:
Link to tracking issue
#29017,
Testing
Unit tests