Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore][scoped-test] Don't do a literal expansion for changed files #37298

Merged
merged 2 commits into from
Jan 18, 2025
Merged

[chore][scoped-test] Don't do a literal expansion for changed files #37298

merged 2 commits into from
Jan 18, 2025

Conversation

pjanotti
Copy link
Contributor

Doing in place expansion leads to hitting bash line size limits, this is a cheap improvement that makes less likely to hit cases like #37287.

Tests on my fork https://github.com/pjanotti/opentelemetry-service-contrib/actions/runs/12836050460/job/35796880868

@pjanotti pjanotti requested a review from a team as a code owner January 17, 2025 20:50
@pjanotti pjanotti requested a review from ChrsMark January 17, 2025 20:50
@pjanotti pjanotti added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jan 17, 2025
@pjanotti pjanotti added the ci-cd CI, CD, testing, build issues label Jan 17, 2025
@atoulme atoulme added the ready to merge Code review completed; ready to merge by maintainers label Jan 17, 2025
@songy23 songy23 merged commit 3f1d256 into open-telemetry:main Jan 18, 2025
175 checks passed
@github-actions github-actions bot added this to the next release milestone Jan 18, 2025
chengchuanpeng pushed a commit to chengchuanpeng/opentelemetry-collector-contrib that referenced this pull request Jan 26, 2025
@pjanotti @chengchuanpeng
[chore][scoped-test] Don't do a literal expansion for changed files (o…
390ff02 
…pen-telemetry#37298)

Doing in place expansion leads to hitting bash line size limits, this is
a cheap improvement that makes less likely to hit cases like open-telemetry#37287.

Tests on my fork
https://github.com/pjanotti/opentelemetry-service-contrib/actions/runs/12836050460/job/35796880868
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atoulme atoulme atoulme approved these changes

@ChrsMark ChrsMark Awaiting requested review from ChrsMark ChrsMark is a code owner automatically assigned from open-telemetry/collector-contrib-approvers

Assignees

@mx-psi mx-psi

Labels
ci-cd CI, CD, testing, build issues ready to merge Code review completed; ready to merge by maintainers Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
v0.118.0
Development

Successfully merging this pull request may close these issues.
4 participants
@pjanotti @atoulme @mx-psi @songy23