[chore][receiver/googlecloudpubsubreceiver] Fix goroutines leak #37311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atoulme
approved these changes
Jan 19, 2025
receiver/googlecloudpubsubreceiver/internal/subscriber_client.go
Outdated
Show resolved
Hide resolved
receiver/googlecloudpubsubreceiver/wrapped_subscriber_client_test.go
Outdated
Show resolved
Hide resolved
Co-authored-by: Kevin N. <[email protected]>
alexvanboxel
force-pushed
the
pubsubreceiver-fixleak
branch
from
17acdaa to
9fa9f4a
Compare
|
The PR has got an internal review, rebased against main and pushed (squashed and force pushed the branch). Removed Draft and is ready for review. |
atoulme
added
the
ready to merge
codeboten
changed the title
chengchuanpeng
pushed a commit
to chengchuanpeng/opentelemetry-collector-contrib
that referenced
this pull request
Jan 26, 2025
…-telemetry#37311) #### Description Fixes goroutines leak by properly closing the underlying gRPC client which is only when we're using an insecure custom endpoint. Enables shutdown tests. #### Link to tracking issue Related to open-telemetry#30438 Co-authored-by: Kevin N. <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes goroutines leak by properly closing the underlying gRPC client which is only when we're using an insecure custom endpoint.
Enables shutdown tests.
Link to tracking issue
Related to #30438