[processor/redaction] Introduce blocked_key_patterns parameter
#37664
+356
−262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odubajDT
force-pushed
the
redaction-blocked-patterns
branch
from
7c82c57 to
b3a192a
Compare
odubajDT
force-pushed
the
redaction-blocked-patterns
branch
from
b3a192a to
71decca
Compare
mx-psi
reviewed
Feb 24, 2025
…shing instead of masking values via 'hash_function' parameter Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
odubajDT
force-pushed
the
redaction-blocked-patterns
branch
from
be2df19 to
b8eed15
Compare
odubajDT
commented
Feb 25, 2025
odubajDT
changed the title
blocked_key_patterns and support hashing instead of masking values via hash_function parameterblocked_key_patterns parameter
mx-psi
approved these changes
Feb 25, 2025
| component: processor/redaction | ||
|
|
||
| # A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`). | ||
| note: "Introduce 'blocked_key_patterns' and support hashing instead of masking values via 'hash_function' parameter" |
There was a problem hiding this comment.
Release note needs an update after the split
| @@ -73,6 +73,11 @@ processors: | |||
| # Any keys in this list are allowed so they don't need to be in both lists. | |||
| ignored_keys: | |||
| - safe_attribute | |||
| # blocked_key_patterns is a list of blocked span attribute key patters. Span attributes | |||
There was a problem hiding this comment.
Suggested change
| # blocked_key_patterns is a list of blocked span attribute key patters. Span attributes | |
| # blocked_key_patterns is a list of blocked span attribute key patterns. Span attributes |
Comment on lines
+120
to
+121
| The value is then masked with a fixed length of asterisks or hashed by a function | ||
| defined in `hash_function`. |
There was a problem hiding this comment.
nit (to make it a bit more future-proof)
Suggested change
| The value is then masked with a fixed length of asterisks or hashed by a function | |
| defined in `hash_function`. | |
| The value is then masked according to the configuration. |
| @@ -43,6 +45,11 @@ func newRedaction(ctx context.Context, config *Config, logger *zap.Logger) (*red | |||
| // TODO: Placeholder for an error metric in the next PR | |||
| return nil, fmt.Errorf("failed to process block list: %w", err) | |||
| } | |||
| blockKeysRegexList, err := makeRegexList(ctx, config.BlockedKeyPatterns) | |||
| if err != nil { | |||
| // TODO: Placeholder for an error metric in the next PR | |||
There was a problem hiding this comment.
Can we have an issue for any TODO in the code?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
blocked_key_patternsparameter to mask values of attributes, which keys match at least one of the defined patternsLink to tracking issue
Fixes #35830
Follow-up
#38161