Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Update prometheus dependency throughout #38139

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ywwg
Copy link

@ywwg ywwg commented Feb 24, 2025

Fixes #37937

Testing

make test passed

Copy link

linux-foundation-easycla bot commented Feb 24, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: ywwg / name: Owen Williams (b4f8768)

@ywwg
Copy link
Author

ywwg commented Feb 24, 2025

not sure if this massive PR is the way to go?

@ywwg
Copy link
Author

ywwg commented Feb 24, 2025

(this is probably redundant to something Jan is working on, oops)

@ArthurSens
Copy link
Member

(this is probably redundant to something Jan is working on, oops)

You mean Jan Fajersky? Do we have a link? I haven't seen his PRs here in the collector 🤔

@ywwg
Copy link
Author

ywwg commented Feb 24, 2025

I was wrong, this is not needed

@ywwg ywwg closed this Feb 24, 2025
@ywwg
Copy link
Author

ywwg commented Feb 24, 2025

reopening because it's good to do this anyway!

@ywwg ywwg reopened this Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Otel collector metrics dots not escaped anymore
2 participants