Skip to content

[processor/transform] Add support for profiles signal #39036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

rockdaboot
Copy link
Contributor

@rockdaboot rockdaboot commented Mar 28, 2025

Initial PR for profiles support in the transform processor.

Fixes #39009

Keeping in draft until the following point are resolved

  • tests are still failing, mostly because attributes in profiles are different compared to other signals. We need a decision on how to expose profile Attributes via OTTL.
  • basic support for profiles in OTTL needs to be merged (added the changes here and built on top of it)

Review

The first commit "[processor/transform] Add support for profiles]" contains the actual changes to the transformprocessor.
The other commits contain the code changes from other PRs that haven't been merged yet but that are required or wanted. Here is the list of PRs and issues.

@rockdaboot
Copy link
Contributor Author

rockdaboot commented Apr 1, 2025

Several test failures needs #39100 to be solved.

Copy link
Member

@MikeGoldsmith MikeGoldsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would help to separate the googleapi dep bump from the functional changes to add OTTL profile support. The PR is pretty big combined at >3k line changes.

@rockdaboot rockdaboot force-pushed the transformprocessor-profiles branch from 58d4e35 to eb590d6 Compare April 7, 2025 07:12
@rockdaboot
Copy link
Contributor Author

rockdaboot commented Apr 7, 2025

It would help to separate the googleapi dep bump from the functional changes to add OTTL profile support. The PR is pretty big combined at >3k line changes.

@MikeGoldsmith The OTTL PR is included here because the transformprocessor changes needs it. That OTTL code alone makes ~2k lines of changes. The OTTL changes will be dropped here after the OTTL PR is merged and before I undraft this PR.

Just rebased, since the changes to the various go.mod files have been fixed in main.

@rockdaboot rockdaboot force-pushed the transformprocessor-profiles branch from c5937d7 to 3b7e2df Compare April 14, 2025 15:36
@fksvs
Copy link

fksvs commented Apr 23, 2025

Any chance this PR will be merged soon?

@rockdaboot
Copy link
Contributor Author

rockdaboot commented Apr 23, 2025

Any chance this PR will be merged soon?

What we need to merge beforehand to get the tests working:

@rockdaboot
Copy link
Contributor Author

@fksvs The updated list of issues / PRs that should be merged first is here.

@rockdaboot rockdaboot force-pushed the transformprocessor-profiles branch 2 times, most recently from 2b498bf to 574ec99 Compare April 29, 2025 08:40
@rockdaboot rockdaboot force-pushed the transformprocessor-profiles branch from 574ec99 to 3ea23e4 Compare April 29, 2025 11:52
@fksvs
Copy link

fksvs commented Apr 29, 2025

Thanks for the update @rockdaboot, I'm currently waiting for the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[processor/transform] Add support for profiles signal
3 participants