fix: close inner reader on ptr clean up #39050
Draft
+19
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rogercoll
force-pushed
the
fix_geoip_flaky
branch
from
14f5491 to
d76b738
Compare
Comment on lines
+45
to
+47
| runtime.AddCleanup(provider, func(geoReader *geoip2.Reader) { | ||
| _ = geoReader.Close() | ||
| }, provider.geoReader) |
There was a problem hiding this comment.
I would prefer not use leverage runtime package to correctly handle cleanup which should be done in a shutdown call.
There was a problem hiding this comment.
Given components must have a Stop method makes sense to do the Close explicitly. I am about the change the PR, just testing out the new runtime method :)
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Link to tracking issue
Fixes
Testing
Documentation