exporter/awss3exporter: Update uniqueKey generation to use lowercase alphanumeric characters #39269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/opentelemetry-collector-contrib into fix_aws_s3exporter_uniquekey
atoulme
reviewed
Apr 9, 2025
|
|
||
| // This follows the original "uniqueness" algorithm | ||
| // This follows the original "uniqueness" algorithm |
There was a problem hiding this comment.
does it still follow the original uniqueness algorithm?
There was a problem hiding this comment.
I removed the existing comments since I'm not sure about the "original "uniqueness" algorithm".
There was a problem hiding this comment.
me neither. Thanks for removing it.
atoulme
approved these changes
Apr 10, 2025
|
moving to draft ; please fix the compilation issues and mark ready for review again. |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary
This update enhances the
uniqueKey()method inPartitionKeyBuilderby replacing the previous numeric-based key generation with a more robust alphanumeric format that includes both uppercase and lowercase letters.Key Changes
Key Generation Logic Updated
100000000–999999999)a–z,A–Z)a–z,A–Z,0–9)Constants Introduced
letters: allowed lowercase and uppercase alphabet characters (a–z,A–Z)digits: allowed numeric characters (0–9)length: total length of the generated key (9)Referring to this, the processing speed is also taken into account.
https://stackoverflow.com/questions/22892120/how-to-generate-a-random-string-of-a-fixed-length-in-go/22892986#22892986
Link to tracking issue
N/A
Testing
Documentation
No documentation changes required as this is an internal implementation detail that
doesn't affect the public API or configuration.