[chore][k8sattributesprocessor] Start informers in the provider function #39301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swiatekm
requested review from
dmitryax,
fatsheep9146,
TylerHelmuth,
ChrsMark and
a team
as code owners
swiatekm
force-pushed
the
chore/k8sattributes/refactor-informer-start
branch
2 times, most recently
from
0bbecfc to
278adbc
Compare
swiatekm
changed the title
swiatekm
force-pushed
the
chore/k8sattributes/refactor-informer-start
branch
from
278adbc to
722c85f
Compare
|
Please address conflict |
ChrsMark
reviewed
Apr 14, 2025
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
swiatekm
force-pushed
the
chore/k8sattributes/refactor-informer-start
branch
2 times, most recently
from
8cea4e9 to
5519c24
Compare
swiatekm
force-pushed
the
chore/k8sattributes/refactor-informer-start
branch
from
5519c24 to
ee9242c
Compare
swiatekm
force-pushed
the
chore/k8sattributes/refactor-informer-start
branch
from
ee9242c to
8daf5d5
Compare
swiatekm
force-pushed
the
chore/k8sattributes/refactor-informer-start
branch
from
8daf5d5 to
a9d7c90
Compare
swiatekm
force-pushed
the
chore/k8sattributes/refactor-informer-start
branch
from
a9d7c90 to
4564ab8
Compare
ChrsMark
reviewed
Jun 12, 2025
ChrsMark
approved these changes
Jun 13, 2025
There was a problem hiding this comment.
The change LGTM. I think we can proceed with this one to unblock the follow-ups coming.
@dmitryax @TylerHelmuth @fatsheep9146 please take a look
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We'd like instances of the k8sattributes processor to share local K8s resource caches (represented by the
informerconcept from client-go). See #36234 for the justification and a broad overview. This change is the first in a series of refactors necessary to make this possible.In order to share informers, the processor cannot be responsible for starting them. This PR moves that logic to informer provider functions. Informers are still stopped by closing a channel provided at construction.
The processor also makes no assumptions about whether the informers will keep running after
Stopis called. As a result, it needs to explicitly track its own event handler registration, and unregister in an orderly matter when stopping.See #36604 for all the refactoring changes put together. I've split this PR out to make review easier.
Link to tracking issue
Part of #36234
Split out from #36604
Testing
Modified existing tests.