[extension/ecsobserver] update to aws-sdk-go-v2 #39397
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Shen <[email protected]>
mjlshen
commented
Apr 15, 2025
| for _, t := range tasks { | ||
| arn2Def[aws.StringValue(t.TaskDefinitionArn)] = nil | ||
| if t.TaskDefinitionArn != nil { |
There was a problem hiding this comment.
A couple tests run into null-pointer exceptions if this nil-check is removed and fail after this nil-check is added. I'll need to spend some more time digging into why and how the mock interacts with this, but thought I would share this draft PR in the meantime in case someone else understands this better.
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
aws-sdk-go is being deprecated on July 31, 2025. This PR updates extension/ecsobserver
Link to tracking issue
Fixes #37727
Testing
I converted the existing unit tests to aws-sdk-go-v2 as well, keeping the original intent of the tests.