[receiver/faroreceiver] Add Faro receiver logic to wireframe #39588
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
receiver/faro
cmd/otelcontribcol
|
Note: I'm basically copying #38224 from @dark0dave and making updates |
|
Moving to draft while this PR is being worked on. Please mark ready to review and ping @dehaansa when done. |
mar4uk
reviewed
Apr 25, 2025
receiver/faroreceiver/utils.go
Outdated
| default: | ||
| return false | ||
| } | ||
| } |
There was a problem hiding this comment.
functions from utils.go seem are not used anywhere
There was a problem hiding this comment.
that's right! removed file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Faro receiver package enables Faro-compatible endpoints. This makes it work.
Link to tracking issue
Fixes #19180
Testing
Adding more unit tests.