Skip to content

Add profiles support to signaltometrics connector #39609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

dmathieu
Copy link
Member

This adds profiles support to the signaltometrics connector.

@dmathieu dmathieu force-pushed the profiles-signaltometrics branch from 73e72a5 to 973ca55 Compare April 24, 2025 09:04
@dmathieu dmathieu marked this pull request as ready for review April 24, 2025 09:49
@dmathieu dmathieu requested a review from a team as a code owner April 24, 2025 09:49
@@ -20,6 +20,7 @@ logs, or metrics).
| traces | metrics | [alpha] |
| logs | metrics | [alpha] |
| metrics | metrics | [alpha] |
| profiles | metrics | [alpha] |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we add some examples to illustrate how the component can be used with this signal?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we don't provide a reference to any example for any signal types as of now. The testdata directory has examples for all signal types, maybe we can add a new section for examples and refer to that directory?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was mostly thinking of sth basic, extending the existing ones so as to have this signal mentioned there as well. I'd be fine with linking to the other directory too, but this can be done outside of this PR.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, that makes sense 👍

Copy link
Member

@lahsivjar lahsivjar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 , thanks for getting this in! LGTM!

@@ -20,6 +20,7 @@ logs, or metrics).
| traces | metrics | [alpha] |
| logs | metrics | [alpha] |
| metrics | metrics | [alpha] |
| profiles | metrics | [alpha] |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we don't provide a reference to any example for any signal types as of now. The testdata directory has examples for all signal types, maybe we can add a new section for examples and refer to that directory?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[connector/signaltometrics] Add support for profiles signal
4 participants