-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Add profiles support to signaltometrics connector #39609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
73e72a5
to
973ca55
Compare
@@ -20,6 +20,7 @@ logs, or metrics). | |||
| traces | metrics | [alpha] | | |||
| logs | metrics | [alpha] | | |||
| metrics | metrics | [alpha] | | |||
| profiles | metrics | [alpha] | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we add some examples to illustrate how the component can be used with this signal?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we don't provide a reference to any example for any signal types as of now. The testdata
directory has examples for all signal types, maybe we can add a new section for examples and refer to that directory?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was mostly thinking of sth basic, extending the existing ones so as to have this signal mentioned there as well. I'd be fine with linking to the other directory too, but this can be done outside of this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, that makes sense 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 , thanks for getting this in! LGTM!
@@ -20,6 +20,7 @@ logs, or metrics). | |||
| traces | metrics | [alpha] | | |||
| logs | metrics | [alpha] | | |||
| metrics | metrics | [alpha] | | |||
| profiles | metrics | [alpha] | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we don't provide a reference to any example for any signal types as of now. The testdata
directory has examples for all signal types, maybe we can add a new section for examples and refer to that directory?
This adds profiles support to the signaltometrics connector.