-
Notifications
You must be signed in to change notification settings - Fork 2.7k
feat: add support for mapping s3 bucket prefix to OTel resource attributes #39634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: add support for mapping s3 bucket prefix to OTel resource attributes #39634
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One change I ask is around choosing which attribute to map, and using both resource as well as metric, log, and span attributes.
Other than that, nice work!
I don't think that's needed. You'd use the groupbyattrs processor earlier in the pipeline to group your incoming data. This way you can make the data map to a nice payload. |
Please address the failing CI. |
Description
Introduced the
resource_attrs_to_s3/s3_prefix
configuration field to enable mapping the S3 bucket prefix to an OpenTelemetry resource attribute. When this field is set, the S3 prefix is determined by the specified resource attribute, withs3uploader/s3_prefix
used as a fallback if the attribute is missing or empty.Link to tracking issue
Fixes #37858
Testing
Documentation
Updated the README to document the new configuration field:
s3uploader/s3_prefix
setting