[receiver/k8sobjectsreceiver] Properly deep copy the K8sObjectsConfig struct #39644
+122
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petern48
requested review from
dmitryax,
TylerHelmuth,
ChrsMark and
a team
as code owners
|
The original issue advised to refactor the config struct to separate mutable fields into a new struct. I tried that, but I felt it was much cleaner to simply keep it as is. I'm not sure if there was reasoning other than code readability, but I'm happy to change this if reviewers still want the refactor. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In
newReceiver(), we perform a shallow copy of the K8sObjectsConfig objects instead of a deep one.Link to tracking issue
Fixes #39553
Testing
Added
TestDeepCopyinside ofconfig_test.go