[chore][exporter/datadogexporter] fix data race in tests again #39802
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
ankitpatel96,
dineshg13,
IbraheemA,
jade-guiton-dd,
liustanley,
mackjmr and
mx-psi
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Having both the otlp grpc exporter & otlp grpc recevier in the tests introduces data race, so move all tests to use HTTP instead. Also make sure to properly close all go routines before tests complete.
Link to tracking issue
Fixes #39782
Fixes #39780
Fixes #39519
Fixes http://github.com/open-telemetry/opentelemetry-collector-contrib/issues/39804