[chore] unexport structs in cumulativetodeltaprocessor #42110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
processor/cumulativetodelta
- State -> state (unexported internal implementation detail) - PrevPoint -> prevPoint (unexported internal field) - Keeps public API structs (ValuePoint, HistogramPoint, MetricPoint, DeltaValue) exported as intended
NoNickeD
force-pushed
the
unexport-cumulativetodelta-structs
branch
from
78a0ade to
a564114
Compare
atoulme
approved these changes
Aug 19, 2025
Contributor
atoulme
left a comment
atoulme
left a comment
There was a problem hiding this comment.
You typically don't need to do this because these are under internal, so they will never be exported by the module. But that's fine.
Contributor
|
@TylerHelmuth what is your take on this PR? is it ok? |
Contributor
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Contributor
Author
|
Hello, Would you have a moment to review this PR when you get a chance? |
TylerHelmuth
approved these changes
Sep 27, 2025
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR unexports internal structs in the cumulativetodeltaprocessor that are not part of the public API, improving API stability by reducing the exposed surface area.
Link to tracking issue
Fixes #40641
Changes Made
Unexported structs:
State→state(internal tracking state implementation detail)PrevPoint→prevPoint(internal field of the state struct)Structs kept exported (as they should be):
Config&MatchMetrics- Part of public configuration APIMetricIdentity- Used in public functionsInitialValue- Used in config with marshalingMetricTracker- Public API of the tracking packageValuePoint- Part of the public tracking APIHistogramPoint- Part of the public tracking APIMetricPoint- Part of the public tracking APIDeltaValue- Part of the public tracking APITesting