feat: add useMemAvailable feature gate #42223
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The useMemAvailable feature gate will use the MemAvailable kernel's statistic to compute the "used" memory usage.
ChrsMark
approved these changes
Aug 28, 2025
receiver/hostmetricsreceiver/internal/scraper/memoryscraper/memory_scraper_linux.go
Show resolved
Hide resolved
Contributor
Author
braydonk
approved these changes
Sep 22, 2025
receiver/hostmetricsreceiver/internal/scraper/memoryscraper/memory_scraper_linux.go
Outdated
Show resolved
Hide resolved
…mory_scraper_linux.go Co-authored-by: Braydon Kains <93549768+braydonk@users.noreply.github.com>
dmitryax
approved these changes
Sep 22, 2025
dmitryax
requested changes
Sep 22, 2025
|
|
||
| var useMemAvailable = featuregate.GlobalRegistry().MustRegister( | ||
| "receiver.hostmetricsreceiver.UseLinuxMemAvailable", | ||
| featuregate.StageAlpha, |
Member
There was a problem hiding this comment.
Looks like we already moved to the updated Used from gopsutil. So we don't need this PR anymore. Or we can make it beta to not get back
Contributor
Author
There was a problem hiding this comment.
Good catch, moved to beta so users can still roll out to the previous formula
rogercoll
force-pushed
the
mem_used_feature_gate
branch
from
ecec14d to
ff010f5
Compare
braydonk
approved these changes
Sep 23, 2025
dmitryax
reviewed
Sep 23, 2025
receiver/hostmetricsreceiver/internal/scraper/memoryscraper/memory_scraper_linux.go
Outdated
Show resolved
Hide resolved
…mory_scraper_linux.go
dmitryax
approved these changes
Sep 23, 2025
receiver/hostmetricsreceiver/internal/scraper/memoryscraper/memory_scraper_linux.go
Outdated
Show resolved
Hide resolved
This was referenced Dec 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The useMemAvailable feature gate will use the MemAvailable kernel's statistic to compute the "used" memory usage. The PR performs the calculation of Used memory by using the raw memory values, this will prevent having a different "Used" value once gopsutil upgrades.
Link to tracking issue
Fixes #42221
Testing
Added a unit test to verify the formulas result to different values.
Documentation