Skip to content

Conversation

@sv-splunk
Copy link
Contributor

@sv-splunk sv-splunk commented Sep 2, 2025

Description

In the field mapping of query_sample attributes in client.go, we are currently mapping `currentAttributes["network.peer.address"] = row["client_addrs"], and in this line client_addrs is misspelled. Actual field name in pg_stat_activity table is client_addr.

Link to tracking issue

Fixes #42447

Testing

Documentation

@VihasMakwana
Copy link
Contributor

@sv-splunk If this PR is ready for review, can you move it from the draft? That way, we can get codeowners to review it.

@sv-splunk sv-splunk marked this pull request as ready for review September 23, 2025 07:28
@sv-splunk sv-splunk requested a review from a team as a code owner September 23, 2025 07:28
@sv-splunk sv-splunk requested a review from crobert-1 September 23, 2025 07:28
@sv-splunk
Copy link
Contributor Author

Hi @VihasMakwana this PR is now ready for review. Thanks

@antonblock
Copy link
Contributor

@sv-splunk it looks like the action failed because of a blip with the golang proxy, do you mind force pushing another commit to trigger a rerun?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this file got included accidentally

@sv-splunk
Copy link
Contributor Author

@crobert-1 could you please help review and merge this PR please? Thanks

Co-authored-by: Curtis Robert <crobert@splunk.com>
@crobert-1 crobert-1 added the ready to merge Code review completed; ready to merge by maintainers label Sep 23, 2025
@sv-splunk
Copy link
Contributor Author

@crobert-1 if you could also merge please ( checks passed )? Thanks

@crobert-1
Copy link
Member

@crobert-1 if you could also merge please ( checks passed )? Thanks

I don't have permission to merge. I've added the ready to merge label to communicate to maintainers (those with permissions to merge) that it's ready 👍

@edmocosta edmocosta merged commit 7c058a5 into open-telemetry:main Sep 24, 2025
203 checks passed
@github-actions github-actions bot added this to the next release milestone Sep 24, 2025
@otelbot
Copy link
Contributor

otelbot bot commented Sep 24, 2025

Thank you for your contribution @sv-splunk! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey.

@sv-splunk sv-splunk deleted the pg-client_addr-fix branch September 29, 2025 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge Code review completed; ready to merge by maintainers receiver/postgresql

Projects

None yet

Development

Successfully merging this pull request may close these issues.

postgresqlreceiver - client_addr in query collection is misspelled as client_addrs

6 participants