[extension/sumologicextension] removing collector name from credential path for sumologic

[pankaj101A]

Description

This pr removes the collector name from the local credentials path that extension uses for authentication. This allows changing the name of the collector without registration. See #42511

Changes

1. Credential key (hashKeyV2) now derives only from InstallationToken and APIBaseURL.
2. collectorName no longer affects credential storage.
3. Added backward compatibility: falls back to old key (v1) if v2 not found.
4. On shutdown, v1 credentials are migrated to v2.
5. Updated tests to cover v1 → v2 migration and ensure correct credential usage.

Link to tracking issue

Resolves #42511

Testing

Testing on local are performed link

Documentation

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: pankaj101A / name: Pankaj Kumar (ad3f8bd, 9d570cb, 56beb59, 31076ad, 5e65f86, b0bb400, db8f28d, 2e8520c, f6cdb07, bc15663, 3f21167, 171fc7c, 5bedede, 879c9b9, 007750e, b79069b, 4f70773, bf65d5e, c27fa31, c605256, 44bc4bf, b03829d, 113abbe, cdc2bfe)

[github-actions]

Welcome, contributor! Thank you for your contribution to opentelemetry-collector-contrib.

Important reminders:

• Please review our Contributing Guidelines.
• Don't forget to sign the Contributor License Agreement (CLA) if you haven't already.

A maintainer will review your pull request soon. Thank you for helping make OpenTelemetry better!

[echlebek]

This PR needs to more carefully describe what the change is, and its impacts. Please post the design document in the PR description and include the background motivation for this change.

[echlebek]

Please file an issue that this PR can resolve. Please include a changelog entry.

[echlebek]

Things are looking generally good to me code-wise. However I am not sure about logging the hash key. I think it would be better to avoid doing that.

[rnishtala-sumo]

@pankaj101A I think we're missing a few scenarios here. The collector name is currently tied to the registration process (probably should have been a UID instead). Changing the collector name without re-registering it may cause some of the metadata like _sourceHost and _sourceCategory to be inconsistent with the collector name which may not be desirable to the customer.

Also, The collector name can currently be set in the sumo extension and is current part of the registration request payload. What happens in a re-registration cycle if we allowed a user to change the collector name outside registration? Would it override the manual change?

Here's the registration payload, which sets collector fields and the timezone along with the collector name:

https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/extension/sumologicextension/extension.go#L433

I don't think we should allow a customer to change the collector name without re-registration, unless we understand the full implications of doing so or decouple the collector name from registration. Other custom collector fields are also currently tied to registration.

cc: @echlebek

[rnishtala-sumo]

Recommend that we re-evaluate this change based on this comment.

[fguimond]

lgtm

[rnishtala-sumo]

LGTM, lets ensure that the tests pass and that the E2E tests test the upgrade scenario to ensure that collectors do not re-register on upgrade.

[echlebek]

@crobert-1 would you be able to approve the pending workflows to run? Thank you!

[crobert-1]

Scoped tests are failing, it appears to be related to this PR. Please fix the failing tests and I'll be able to review from there 👍

[crobert-1]

Suggested change

	logger.Info("credentials not found, trying legacy credentials", zap.Error(err))
	logger.Info("credentials not found, using legacy credentials", zap.Error(err))

Nit: When I see the word trying I assume some other work will happen, but that's not the case. I think this wording may be more clear. Feel free to drop.

[github-actions]

Welcome, contributor! Thank you for your contribution to opentelemetry-collector-contrib.

Important reminders:

• Please review our Contributing Guidelines.
• Don't forget to sign the Contributor License Agreement (CLA) if you haven't already.

A maintainer will review your pull request soon. Thank you for helping make OpenTelemetry better!

[otelbot]

Thank you for your contribution @pankaj101A! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey.