[fix] Correctly add Metric Labels as Metric Attributes in OTel, not as Resource Attributes #42473
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdonkers
requested review from
a team,
TylerHelmuth and
dashpole
as code owners
mdonkers
changed the title
mdonkers
changed the title
Contributor
|
I will review by next Tuesday. |
Contributor
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Contributor
Author
|
still waiting for approval... Not stale. |
dashpole
approved these changes
Sep 23, 2025
dashpole
added
ready to merge
Contributor
Contributor
|
Sorry for the delay @mdonkers |
Contributor
Author
|
@dashpole no worries! We had a work-around for this in our product as we saw customers sending data coming from this receiver (and thus seeing some unexpected attributes). We'll need to keep the work-around in place as customers will take time to upgrade. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes issue #42232
By no longer adding Metric Labels from the source metric, to the target Resource Attributes.
Instead for every metric, add the Labels as Metric Attributes (which was happening for 'histograms' already)
Link to tracking issue
Fixes #42232
Testing
As there was only a test for gauges, I extended it to validate attributes are correctly converted.