Oracle Cloud Resource Detection Processor #42632

geekdave · 2025-09-11T00:19:51Z

Description

Implements a resource detection processor for Oracle Cloud Infrastructure (OCI) to enrich telemetry with environment metadata.

Uses semantic conventions for OCI: open-telemetry/semantic-conventions#1720

Link to tracking issue

Fixes #35091

Testing

Added unit tests following existing conventions
Built custom otel collector using ocb, ran on Oracle Kubernetes Engine (OKE) cluster, and verified that resulting metrics are enriched with these labels:

Documentation

Updated processor documentation (processor/resourcedetectionprocessor/README.md) to describe Oracle Cloud detection usage and configuration.
Added Go docstrings and inline comments for maintainability.

github-actions · 2025-09-11T00:20:02Z

Welcome, contributor! Thank you for your contribution to opentelemetry-collector-contrib.

Important reminders:

Please review our Contributing Guidelines.
Don't forget to sign the Contributor License Agreement (CLA) if you haven't already.

A maintainer will review your pull request soon. Thank you for helping make OpenTelemetry better!

atoulme · 2025-09-12T01:00:59Z

Will you be owning this code moving forward?

geekdave · 2025-09-12T16:10:02Z

@atoulme Yes! I, along with two of my colleagues at Oracle, @tonychoe and @raphaelfan can be the codeowners.

We discussed ownership and project sponsorship with @dashpole (who volunteered to be the project sponsor) in this linked issue:
#35091

dashpole · 2025-09-15T15:57:45Z

Feel free to ping me on slack once tests are passing

github-actions · 2025-09-17T06:36:07Z

Welcome, contributor! Thank you for your contribution to opentelemetry-collector-contrib.

Important reminders:

Please review our Contributing Guidelines.
Don't forget to sign the Contributor License Agreement (CLA) if you haven't already.

A maintainer will review your pull request soon. Thank you for helping make OpenTelemetry better!

atoulme · 2025-09-17T06:36:32Z

Moving to draft while you work out the issues, please mark ready for review when CI passes.

geekdave · 2025-09-18T21:14:37Z

@atoulme Tests are now passing! I've been working with @dashpole who has been helping to manually trigger test runs. The most recent run passed. However, when I clicked on Ready for Review it seems to have cleared the recent test results. It may require a re-trigger?

geekdave · 2025-09-18T21:21:32Z

Also wanted to mention that I tried to add myself and my Oracle teammates as codeowners in our metadata.yaml file, but CI failed because we are not members of the OTel GitHub Org. @dashpole mentioned this is a classic "chicken and egg" problem. For now I removed us from the list. But I wanted to reiterate that we are committed to maintaining and supporting this component. I'm looking forward to participating in meaningful ways to work towards earning org membership (and codeowner status)!

atoulme · 2025-09-18T22:02:53Z

@geekdave you can add yourself to the allowlist under cmd/githubgen/allowlist.txt one username per line if you would like to be codeowners ahead of joining as members. Or we can add you post facto.

I have triggered the build.

atoulme · 2025-09-18T22:03:13Z

@dashpole please review

geekdave · 2025-09-18T22:28:31Z

@atoulme Thanks for the tip! If it's alright I will hold my breath and back away slowly from this PR's green CI status, and update the allowlist as a follow-up PR after-the-fact. 😉

dashpole · 2025-09-19T13:40:51Z

processor/resourcedetectionprocessor/internal/oraclecloud/oraclecloud.go

+// Detect detects system metadata and returns a resource with the available ones
+func (d *Detector) Detect(ctx context.Context) (resource pcommon.Resource, schemaURL string, err error) {
+	compute, err := d.provider.Metadata(ctx)
+	if err != nil {


This approach is OK, but you may want to try and differentiate between the case where someone is not on oracle cloud (where return pcommon.NewResource(), "", nil is correct), and the case where someone is on oracle cloud, but the request failed (e.g. a timeout?). Currently, it is possible for a user to end up with missing resource attributes in the latter case.

dashpole

Feedback above is non-blocking, but I would recommend filing an issue to track fixing it if you choose not to address it in this PR.

atoulme · 2025-09-19T15:13:44Z

@geekdave please file an issue or fix it here, and we can merge.

geekdave · 2025-09-19T18:15:26Z

@atoulme @dashpole I've created an issue addressing the above feedback, and suggesting a few approaches. I'll investigate further. In the meantime if any of the possible approaches in the issue stand out as preferable, please feel free to comment: #42794

github-actions · 2025-09-22T18:34:52Z

Welcome, contributor! Thank you for your contribution to opentelemetry-collector-contrib.

Important reminders:

Please review our Contributing Guidelines.
Don't forget to sign the Contributor License Agreement (CLA) if you haven't already.

A maintainer will review your pull request soon. Thank you for helping make OpenTelemetry better!

otelbot · 2025-09-23T13:07:15Z

Thank you for your contribution @geekdave! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey.

Oracle Cloud Resource Detection Processor

7179bc6

geekdave requested review from a team and dashpole as code owners September 11, 2025 00:19

github-actions bot assigned edmocosta Sep 11, 2025

github-actions bot added the first-time contributor PRs made by new contributors label Sep 11, 2025

github-actions bot added processor/resourcedetection Resource detection processor internal/metadataproviders labels Sep 11, 2025

github-actions bot requested a review from Aneurysm9 September 11, 2025 00:20

Merge branch 'main' into oracle-resource-det-proc

9b7d2b8

geekdave and others added 2 commits September 12, 2025 08:52

add chloggen change log

9389e70

Merge branch 'main' into oracle-resource-det-proc

584c3a5

atoulme added the Accepted Component New component has been sponsored label Sep 17, 2025

atoulme marked this pull request as draft September 17, 2025 06:35

geekdave and others added 11 commits September 17, 2025 10:22

add missing vanity imports

d9f4d2d

Fix lint errors

5e0c32b

Merge branch 'main' into oracle-resource-det-proc

ed29abf

regenerate generated files

3d78b68

add codeowners

e88b9fb

add project sponsor dashpole as "codeowner of last resort"

ee716ee

fix another round of lint errors

6cc6e4b

add new labels

2c8efdb

remove non-otel members from codeowners until we can get approved

eba7208

update generated codeowners

b97a320

Merge branch 'main' into oracle-resource-det-proc

a7fc5f4

Merge branch 'main' into oracle-resource-det-proc

9695853

geekdave marked this pull request as ready for review September 18, 2025 21:08

github-actions bot assigned dmitryax Sep 18, 2025

dashpole reviewed Sep 19, 2025

View reviewed changes

dashpole approved these changes Sep 19, 2025

View reviewed changes

geekdave mentioned this pull request Sep 19, 2025

Oracle Cloud Resource Detector – Error Handling Enhancements #42794

Closed

Merge branch 'main' into oracle-resource-det-proc

b8a4015

dashpole added the ready to merge Code review completed; ready to merge by maintainers label Sep 22, 2025

songy23 merged commit 3d381f2 into open-telemetry:main Sep 23, 2025
322 of 324 checks passed

github-actions bot added this to the next release milestone Sep 23, 2025

dashpole mentioned this pull request Sep 23, 2025

[processor/resourcedetection] Add support for Digitalocean #42803

Closed

This was referenced Dec 8, 2025

Create Oracle Cloud SemConv Approvers Group open-telemetry/community#3185

Closed

REQUEST: New membership for geekdave open-telemetry/community#3187

Closed

Oracle Cloud Resource Detection Processor #42632

Oracle Cloud Resource Detection Processor #42632

Uh oh!

Conversation

geekdave commented Sep 11, 2025

Description

Link to tracking issue

Testing

Documentation

Uh oh!

github-actions bot commented Sep 11, 2025

Uh oh!

atoulme commented Sep 12, 2025

Uh oh!

geekdave commented Sep 12, 2025

Uh oh!

dashpole commented Sep 15, 2025

Uh oh!

github-actions bot commented Sep 17, 2025

Uh oh!

atoulme commented Sep 17, 2025

Uh oh!

geekdave commented Sep 18, 2025

Uh oh!

geekdave commented Sep 18, 2025

Uh oh!

atoulme commented Sep 18, 2025

Uh oh!

atoulme commented Sep 18, 2025

Uh oh!

geekdave commented Sep 18, 2025

Uh oh!

dashpole Sep 19, 2025

Choose a reason for hiding this comment

Uh oh!

dashpole left a comment

Choose a reason for hiding this comment

Uh oh!

atoulme commented Sep 19, 2025

Uh oh!

geekdave commented Sep 19, 2025

Uh oh!

github-actions bot commented Sep 22, 2025

Uh oh!

Uh oh!

otelbot bot commented Sep 23, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants