[exporter/datadog] Stop doing character validation for API keys #42783
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
IbraheemA,
ankitpatel96,
dineshg13,
jade-guiton-dd,
liustanley and
mackjmr
Contributor
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Contributor
|
This solved a particular bug did it not? I'll have to look back to see if the underlying issue was fixed. |
jackgopack4
approved these changes
Oct 6, 2025
Contributor
jackgopack4
left a comment
jackgopack4
left a comment
There was a problem hiding this comment.
I'm fine with merging this, but we will need to re-open/re-investigate #36509
graphaelli
pushed a commit
to graphaelli/opentelemetry-collector-contrib
that referenced
this pull request
Oct 6, 2025
…-telemetry#42783) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> Stops doing validation of characters in API key. Validation of secrets is challenging. Furthermore, any possible changes on the API key format would mean users would have to upgrade their clients; being more flexible and leaving validation for runtime helps avoid unnecessary upgrades. #### Link to tracking issue Fixes open-telemetry#42677
mashhurs
pushed a commit
to mashhurs/opentelemetry-collector-contrib
that referenced
this pull request
Oct 9, 2025
…-telemetry#42783) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> Stops doing validation of characters in API key. Validation of secrets is challenging. Furthermore, any possible changes on the API key format would mean users would have to upgrade their clients; being more flexible and leaving validation for runtime helps avoid unnecessary upgrades. #### Link to tracking issue Fixes open-telemetry#42677
tommyers-elastic
pushed a commit
to tommyers-elastic/opentelemetry-collector-contrib
that referenced
this pull request
Oct 10, 2025
…-telemetry#42783) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> Stops doing validation of characters in API key. Validation of secrets is challenging. Furthermore, any possible changes on the API key format would mean users would have to upgrade their clients; being more flexible and leaving validation for runtime helps avoid unnecessary upgrades. #### Link to tracking issue Fixes open-telemetry#42677
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Stops doing validation of characters in API key. Validation of secrets is challenging. Furthermore, any possible changes on the API key format would mean users would have to upgrade their clients; being more flexible and leaving validation for runtime helps avoid unnecessary upgrades.
Link to tracking issue
Fixes #42677