Skip to content

use schema.Metadata structure instead of labels.MetricName #42798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
edmocosta merged 4 commits into from
Sep 25, 2025
Merged

use schema.Metadata structure instead of labels.MetricName #42798

edmocosta merged 4 commits into from
Sep 25, 2025

Conversation

@leiwingqueen
Copy link
Contributor

@leiwingqueen leiwingqueen commented Sep 20, 2025 •
edited
Loading

Description

labels.MetricName has been deprecated. Use schema.Metadata structure and its methods instead of labels.MetricName.

Link to tracking issue

Fixes #42799

Testing

Documentation

@github-actions github-actions bot added the first-time contributor PRs made by new contributors label Sep 20, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Sep 20, 2025

Welcome, contributor! Thank you for your contribution to opentelemetry-collector-contrib.

Important reminders:

A maintainer will review your pull request soon. Thank you for helping make OpenTelemetry better!

@github-actions github-actions bot requested a review from perebaj September 20, 2025 14:59
@paulojmdias
Copy link
Member

paulojmdias commented Sep 21, 2025

@leiwingqueen thanks for your PR! Can you please add a changelog entry? See https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/CONTRIBUTING.md#adding-a-changelog-entry

@leiwingqueen
Copy link
Contributor Author

leiwingqueen commented Sep 22, 2025

@leiwingqueen thanks for your PR! Can you please add a changelog entry? See https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/CONTRIBUTING.md#adding-a-changelog-entry

@paulojmdias Done!

ArthurSens
ArthurSens requested changes Sep 23, 2025
View reviewed changes
Copy link
Member

@ArthurSens ArthurSens left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has no user-facing change, so I'd prefer not to include a changelog entry, actually 😅

Could you please remove the file? I've added the label to make CI happy, even without the changelog entry

@ArthurSens ArthurSens added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Sep 23, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Sep 23, 2025

Welcome, contributor! Thank you for your contribution to opentelemetry-collector-contrib.

Important reminders:

A maintainer will review your pull request soon. Thank you for helping make OpenTelemetry better!

@leiwingqueen
Copy link
Contributor Author

leiwingqueen commented Sep 24, 2025

This has no user-facing change, so I'd prefer not to include a changelog entry, actually 😅

Could you please remove the file? I've added the label to make CI happy, even without the changelog entry

@ArthurSens Done.

ArthurSens
ArthurSens approved these changes Sep 25, 2025
View reviewed changes
Copy link
Member

@ArthurSens ArthurSens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ArthurSens ArthurSens added the ready to merge Code review completed; ready to merge by maintainers label Sep 25, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Sep 25, 2025

Welcome, contributor! Thank you for your contribution to opentelemetry-collector-contrib.

Important reminders:

A maintainer will review your pull request soon. Thank you for helping make OpenTelemetry better!

@edmocosta edmocosta merged commit 61aeb11 into open-telemetry:main Sep 25, 2025
185 of 186 checks passed
@github-actions github-actions bot added this to the next release milestone Sep 25, 2025
@otelbot
Copy link
Contributor

otelbot bot commented Sep 25, 2025

Thank you for your contribution @leiwingqueen! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dashpole dashpole dashpole approved these changes

@ArthurSens ArthurSens ArthurSens approved these changes

@VihasMakwana VihasMakwana VihasMakwana approved these changes

@perebaj perebaj Awaiting requested review from perebaj

+1 more reviewer

@Frapschen Frapschen Frapschen approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ChrsMark ChrsMark

Labels

first-time contributor PRs made by new contributors ready to merge Code review completed; ready to merge by maintainers receiver/prometheusremotewrite Skip Changelog PRs that do not require a CHANGELOG.md entry

Projects

None yet

Milestone

v0.137.0

Development

Successfully merging this pull request may close these issues.

[receiver/prometheusremotewritereceiver] use schema.Metadata structure instead of labels.MetricName

8 participants

@leiwingqueen @paulojmdias @dashpole @ArthurSens @Frapschen @VihasMakwana @ChrsMark @edmocosta