fix jmx-scraper update URL + fix bogus 1.49.0 hash #43067
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Welcome, contributor! Thank you for your contribution to opentelemetry-collector-contrib. Important reminders:
A maintainer will review your pull request soon. Thank you for helping make OpenTelemetry better! |
songy23
approved these changes
Sep 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When support for the jmx-scraper component was added to the
jmxreceiver, it was not yet available in github release assets, hence for automatic update automation it was downloaded from maven central.Unfortunately, the URL pattern for maven central artifacts was bogus and returned a 404, which in turn produced a constant hash, this failure was silent for the update to 1.49.0, at least for the CI, as any user would have not been able to use it.
We can now use the github release assets URL as
jmx-scraperartifact is now available, and thus the URL is consistent with the one used forjmx-metricsartifact.This was only caught when the update for 1.50.0 triggered a duplicate hash because the same 404 page was hashed and added to the dictionary in #43024.
cc @rogercoll