-
Notifications
You must be signed in to change notification settings - Fork 3.2k
[receiver/filelog] Suppress repeated permission denied errors #44350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
|
|
Welcome, contributor! Thank you for your contribution to opentelemetry-collector-contrib. Important reminders:
A maintainer will review your pull request soon. Thank you for helping make OpenTelemetry better! |
|
@andrzej-stencel @atoulme - gentle bump on this PR |
VihasMakwana
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need a mutex? AFAIK, calls to makeFingerprint are serialised. Could you confirm this?
Also, @andrzej-stencel is on sick leave until starting of December. It might take some time to get this merged.
Hey @VihasMakwana - You are correct! Taking a second deeper look, I saw that only a single goroutine calls |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Description
Added logic to suppress repeated error logs due to file permission errors within the
filelogreceiver.makeFingerprintto check for permission errors via os.isPermissionLink to tracking issue
Fixes #39491
Testing
New unit test verifying:
Previously unreadable...message appears.NOTE: Test skips Windows due to unreliable os.Chmod behavior
Documentation
Added changelog yaml entry summarizing the issue and fix.