Modified code to run TestGetShutdown without failures. #45196
+133
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Welcome, contributor! Thank you for your contribution to opentelemetry-collector-contrib. Important reminders:
A maintainer will review your pull request soon. Thank you for helping make OpenTelemetry better! |
github-actions
bot
added
first-time contributor
Nitishrajj
force-pushed
the
43918-testgetshutdown
branch
from
19ae197 to
830ceeb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TestGetShutdown was starting real Kubernetes informers, which triggered exec-based authentication plugins from client-go. This caused noisy logs and Windows CI failures after recent Kubernetes client upgrades.
This PR introduces a test-only option to disable informer startup and updates TestGetShutdown to use it. The change ensures the test validates client lifecycle behaviour without starting background go routines or making Kubernetes API calls. Production behaviour remains unchanged.
Link to issue : 43918
Testing:
Reproduced the failure locally
Updated TestGetShutdown to disable informers and reset singleton state
Verified the test passes cleanly without Kubernetes reflector or exec-plugin errors using below command.
go test ./internal/aws/k8s/k8sclient -run TestGetShutdown -v