fix(extension/oidcauth): allow collector to start when some OIDC issuers are unreachable #45207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rs are unreachable When multiple OIDC providers are configured, the collector now starts even if some providers are unreachable. A warning is logged for each unreachable provider. The collector only fails to start if ALL configured providers are unreachable. Fixes open-telemetry#45206 Signed-off-by: majiayu000 <[email protected]>
Contributor
|
Welcome, contributor! Thank you for your contribution to opentelemetry-collector-contrib. Important reminders:
A maintainer will review your pull request soon. Thank you for helping make OpenTelemetry better! |
Contributor
|
This looks like a bot that "fixed" #45206 without reading it. |
Author
|
@asweet-confluent Thanks for calling that out — I read the issue again. My follow‑up change aligns with the issue’s Expected Result: Start() should warn and still succeed even if issuers are unreachable (including single‑issuer config). If you’d prefer “fail only when all providers fail,” or add a config flag, I can adjust accordingly. Which behavior do you want? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #45206
Summary
When multiple OIDC providers are configured, the collector now starts successfully even if some providers are unreachable, as long as at least one provider is reachable.
Changes
Start()to log warnings for unreachable providers instead of failing immediately