-
Notifications
You must be signed in to change notification settings - Fork 3.2k
[pkg/ottl] Fix handling of signed numbers, floating point constants like "3." #45223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kentquirk
wants to merge
11
commits into
open-telemetry:main
Choose a base branch
from
honeycombio:kent.fix_numeric_parsing
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[pkg/ottl] Fix handling of signed numbers, floating point constants like "3." #45223
kentquirk
wants to merge
11
commits into
open-telemetry:main
from
honeycombio:kent.fix_numeric_parsing
+282
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulojmdias
reviewed
Jan 3, 2026
Co-authored-by: Paulo Dias <[email protected]>
TylerHelmuth
approved these changes
Jan 5, 2026
edmocosta
reviewed
Jan 5, 2026
edmocosta
reviewed
Jan 7, 2026
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add the .yaml extension to this file?
Member
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doh. Sorry about that.
Co-authored-by: Edmo Vamerlatti Costa <[email protected]>
Co-authored-by: Edmo Vamerlatti Costa <[email protected]>
Co-authored-by: Edmo Vamerlatti Costa <[email protected]>
Co-authored-by: Edmo Vamerlatti Costa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I'm trying to write an OTTL plugin for syntax coloring. I needed to write an OTTL grammar, and while doing so I realized there are bugs in OTTL's handling of numeric expressions.
In particular, the OTTL math expression parser did not correctly handle unary signs for plus
and minus. Expressions like "3+-5" would not parse correctly. Additionally,
floating point constants that had a decimal point but no fractional digits
(e.g., "3.") were not handled properly and could crash the parser. This change
moves the sign handling out of the lexer and into the parser.
3.). These are now parsed as valid floating point numbers.Link to tracking issue
#45222
Testing
Both lexer and parser tests were added to the ottl package.