[WIP] Improve SQLServer metrics accuracy by reducing the warm-up delay and including all available cumulative records from DB #45227
+117
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sv-splunk
changed the title
XSAM
reviewed
Jan 6, 2026
| // We just send down the metrics corresponding to that single execution as it is. | ||
| // If execution count in DB is not 1 then we send down the delta values. | ||
| execCountInDB := executionCountVal.(int64) | ||
| if execCountInDB != 1 { |
Member
There was a problem hiding this comment.
I don't understand why treating 1 as a special case. If a query only runs for once, will this change report this query each time the collector restarts?
Contributor
Author
There was a problem hiding this comment.
@XSAM I have details in the PR description, please check and let me know if you need more info.
sv-splunk
changed the title
…essing a negligable edge case.
sv-splunk
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SQLServer metrics reporting is improved by reducing the warm-up delay and providing accurate insights sooner.
In the existing implementation, only the
totalElapsedTimemetric is cached during the first collection, while all other metrics are skipped and cached only in the second collection. As a result, delta calculations are not possible at that point and can only be performed starting from the third collection.This PR fixes the issue by caching all metrics starting from the first collection onwards.
Also to get the total of all cumulative metrics records from sys.dm_exec_query_stats, we should move the time period filter from inner query to outer. With that being within the inner query, we were considering only records created within the collection window, resulting in calculation of a wrong total of cumulative records.
Link to tracking issue
Fixes #45228
Testing
Unit tests added. Also ran in internal environment for extended testing.