Skip to content

Conversation

@cyrille-leclerc
Copy link
Member

@cyrille-leclerc cyrille-leclerc commented Jan 6, 2026

Description

Add documentation to help fix Span Metrics Connector's metrics high cardinality problems.

Note that @iblancasa and @Frapschen reviewed the PR to introduce the set_semconv_span_name() function #43145 , reviewing this documentation PR should be straightforward to them.

Link to tracking issue

None

Testing

N/A

Documentation

This is a documentation PR

@cyrille-leclerc cyrille-leclerc marked this pull request as ready for review January 6, 2026 11:10
@cyrille-leclerc cyrille-leclerc requested a review from a team as a code owner January 6, 2026 11:10
Copy link
Member

@crobert-1 crobert-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Documentation-only changes don't require changelogs, and I'd probably prefer it if we removed the entry. I can add a label to this PR to make sure CI still passes without it 👍

@crobert-1 crobert-1 added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jan 6, 2026
@cyrille-leclerc
Copy link
Member Author

LGTM. Documentation-only changes don't require changelogs, and I'd probably prefer it if we removed the entry. I can add a label to this PR to make sure CI still passes without it 👍

I got the message No changelog entry was added to the ./.chloggen/ directory. ... Alternately, add either "[chore]" to the title of the pull request or add the "Skip Changelog" label if this job should be skipped.

Can you add the label "skip changelog"?

@crobert-1
Copy link
Member

Can you add the label "skip changelog"?

I've added it. For future reference, the alternative is to add [chore] to the beginning of your PR's title (source). 👍

@crobert-1 crobert-1 added the ready to merge Code review completed; ready to merge by maintainers label Jan 6, 2026
@songy23 songy23 merged commit 4f2f319 into open-telemetry:main Jan 6, 2026
175 checks passed
@github-actions github-actions bot added this to the next release milestone Jan 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

connector/spanmetrics ready to merge Code review completed; ready to merge by maintainers Skip Changelog PRs that do not require a CHANGELOG.md entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants