[processor/k8sattributes] introduce semconv compaint feature gate pair #45307
+172
−174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odubajDT
force-pushed
the
k8sattributes-semconv-gates
branch
from
a20f3e1 to
d1118cb
Compare
odubajDT
requested review from
a team,
ChrsMark,
TylerHelmuth,
dmitryax and
fatsheep9146
as code owners
ChrsMark
reviewed
Jan 12, 2026
Member
ChrsMark
left a comment
ChrsMark
left a comment
There was a problem hiding this comment.
Thank's @odubajDT . I think we should wait for open-telemetry/opentelemetry-collector#14273 to ensure we indeed follow the decided feature gate schema.
Member
|
open-telemetry/opentelemetry-collector/pull/14273 is on the merge queue :) |
odubajDT
force-pushed
the
k8sattributes-semconv-gates
branch
from
d151980 to
b064c9e
Compare
ChrsMark
reviewed
Jan 28, 2026
ChrsMark
reviewed
Jan 28, 2026
ChrsMark
reviewed
Jan 29, 2026
Member
ChrsMark
left a comment
ChrsMark
left a comment
There was a problem hiding this comment.
LGTM.
Tested that manually with several combinations and seems to work as expected:
command:
extraArgs:
#- --feature-gates=+processor.k8sattributes.EmitV1K8sConventions,+processor.k8sattributes.DontEmitV0K8sConventions # should emit v1 -> OK
#- --feature-gates=+processor.k8sattributes.EmitV1K8sConventions,-processor.k8sattributes.DontEmitV0K8sConventions # should emit both -> OK
#- --feature-gates=-processor.k8sattributes.EmitV1K8sConventions,+processor.k8sattributes.DontEmitV0K8sConventions # should error -> OK
- --feature-gates=processor.k8sattributes.EmitV1K8sConventions # should emit both -> OK
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
odubajDT
force-pushed
the
k8sattributes-semconv-gates
branch
from
5de4a2b to
941624a
Compare
ChrsMark
approved these changes
Jan 29, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduce semantic conventions compliant feature gate pair for k8sattributes processor
Link to tracking issue
Fixes #44693 Part of #44589