-
Notifications
You must be signed in to change notification settings - Fork 3.3k
[pkg/stanza] Fix transformer operators logging errors at ERROR level when on_error is set to quiet mode
#45366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…when `on_error` is set to quiet mode Signed-off-by: Paulo Dias <paulodias.gm@gmail.com>
iblancasa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you should introduce tests for batch processing with quiet mode, behavior when all entries in a batch fail or a mix.
Signed-off-by: Paulo Dias <paulodias.gm@gmail.com>
|
Thanks for the review @iblancasa, I pushed the changes related to your review, including tests for batch processing with quiet mode 🙏 |
Signed-off-by: Paulo Dias <paulodias.gm@gmail.com>
andrzej-stencel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this @paulojmdias. This fixes it for many operators, although not for all. I think it would be useful to explicitly list the operators that are fixed and those that still need fixing. This would help guide future contributions.
Ideally the test additions would be contributed in a separate pull request, as those changes are orthogonal to the fix, aren't they? This way, if we have to revert this change for whatever reason, the test additions would not need to be reverted.
|
@andrzej-stencel, Looking into the operators, I think the ones which missing are That's a fair point. I've moved the tests for PR #45688 |
…rs (#45688) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Split tests from PR #45366 <!-- Issue number (e.g. #1234) or full URL to issue, if applicable. --> #### Link to tracking issue Relates to #42646 Signed-off-by: Paulo Dias <paulodias.gm@gmail.com>
|
/rerun |
|
@andrzej-stencel, here are the PRs for the ones that are missing:
I'll mark this as ready for merge now 🙏 |
f5acb3b
into
open-telemetry:main
Description
Fix transformer operators logging errors at ERROR level when
on_erroris set to quiet mode (send_quietordrop_quiet)Link to tracking issue
Fixes #42646
Testing
Updated unit tests and added tests to all operators, which should support
on_errorconfiguration.