Skip to content

Conversation

@paulojmdias
Copy link
Member

Description

Fix transformer operators logging errors at ERROR level when on_error is set to quiet mode (send_quiet or drop_quiet)

Link to tracking issue

Fixes #42646

Testing

Updated unit tests and added tests to all operators, which should support on_error configuration.

…when `on_error` is set to quiet mode

Signed-off-by: Paulo Dias <paulodias.gm@gmail.com>
@paulojmdias paulojmdias requested review from a team and andrzej-stencel as code owners January 12, 2026 22:11
Copy link
Contributor

@iblancasa iblancasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should introduce tests for batch processing with quiet mode, behavior when all entries in a batch fail or a mix.

paulojmdias and others added 2 commits January 15, 2026 14:46
Signed-off-by: Paulo Dias <paulodias.gm@gmail.com>
@paulojmdias
Copy link
Member Author

Thanks for the review @iblancasa, I pushed the changes related to your review, including tests for batch processing with quiet mode 🙏

Signed-off-by: Paulo Dias <paulodias.gm@gmail.com>
Copy link
Member

@andrzej-stencel andrzej-stencel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this @paulojmdias. This fixes it for many operators, although not for all. I think it would be useful to explicitly list the operators that are fixed and those that still need fixing. This would help guide future contributions.

Ideally the test additions would be contributed in a separate pull request, as those changes are orthogonal to the fix, aren't they? This way, if we have to revert this change for whatever reason, the test additions would not need to be reverted.

@paulojmdias
Copy link
Member Author

@andrzej-stencel, Looking into the operators, I think the ones which missing are recombine, syslog, container and filter. Please let me know if I'm right to move forward with documentation and/or issues/PRs for it 🙏

That's a fair point. I've moved the tests for PR #45688

andrzej-stencel pushed a commit that referenced this pull request Jan 28, 2026
…rs (#45688)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

Split tests from PR #45366

<!-- Issue number (e.g. #1234) or full URL to issue, if applicable. -->
#### Link to tracking issue
Relates to #42646

Signed-off-by: Paulo Dias <paulodias.gm@gmail.com>
@paulojmdias
Copy link
Member Author

/rerun

@paulojmdias
Copy link
Member Author

@paulojmdias paulojmdias added the ready to merge Code review completed; ready to merge by maintainers label Jan 28, 2026
@andrzej-stencel andrzej-stencel merged commit f5acb3b into open-telemetry:main Jan 29, 2026
329 of 330 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg/stanza ready to merge Code review completed; ready to merge by maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[pkg/stanza] move operator produces log error event when on_error set to send_quiet. error - failed to emit token

4 participants