-
Notifications
You must be signed in to change notification settings - Fork 3.3k
[processor/resourcedetection] Add support for Alibaba Cloud ECS #45633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
paulojmdias
wants to merge
11
commits into
open-telemetry:main
Choose a base branch
from
paulojmdias:feat/resourcedetection_alibabacloud
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[processor/resourcedetection] Add support for Alibaba Cloud ECS #45633
paulojmdias
wants to merge
11
commits into
open-telemetry:main
from
paulojmdias:feat/resourcedetection_alibabacloud
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paulo Dias <[email protected]>
Member
Author
|
/rerun |
Signed-off-by: Paulo Dias <[email protected]>
Signed-off-by: Paulo Dias <[email protected]>
Contributor
|
Do we have conventions for |
Member
Author
Yes, I'm calling the conventions on the code also. |
iblancasa
reviewed
Jan 26, 2026
Signed-off-by: Paulo Dias <[email protected]>
Signed-off-by: Paulo Dias <[email protected]>
Member
Author
|
/rerun |
Member
Author
|
/rerun |
Member
Author
|
@dashpole @iblancasa Can I get your review here, please? 🙏 |
iblancasa
approved these changes
Jan 29, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
internal/metadataproviders
processor/resourcedetection
Resource detection processor
waiting-for-code-owners
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for resource detection in Alibaba Cloud ECS. It uses values for
cloud.platformandcloud.providerwhich are already in semantic conventions.I'm proposing to be a code owner for this detector 🙌
Link to tracking issue
Fixes #45632
Testing
Added multiple tests, including E2E tests, and I personally tested them on a ECS server.
Documentation
Updated the README.md with this new detector.