[chore] Add display name to skywalker encoder #45649
Open
+140
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…emetry-collector-contrib into skywalker-display-name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Uses the new display_name and description metadata fields for the skywalker encoder.
This module was missing the
doc.gofile so the mdatagen tasks were not executing properly, so I added that and it also generated the other files. The generated component test failed due to the factory returning nil for the config, so I added an empty struct to prevent that and for the tests to pass.Related to open-telemetry/opentelemetry-collector#14114 and open-telemetry/opentelemetry-collector#14400
Continuation from #45537 #45554 #45599