Skip to content

Conversation

@markobachvarovski
Copy link

@markobachvarovski markobachvarovski commented Jan 26, 2026

Description

Adding the option to enter the Supervisor ID before first launch. This is particularly useful when pre-registering collectors

Link to tracking issue

#45596

Fixes

Testing

Extended the persistence tests to also test the following scenarios:

  1. When creating a persistent_state file, if instance_id is provided, use that as the instance_id
  2. If instance_id is not provided or is provided but is invalid, fall back to creating one randomly (existing behaviour)

Manually tested and verified that changing isntance_id after first launch does NOT return the modified instance_id, meaning once it's persisted to file, config changes don't affect it (as expected)

Documentation

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jan 26, 2026

CLA Signed

The committers listed above are authorized under a signed CLA.

@github-actions github-actions bot added the first-time contributor PRs made by new contributors label Jan 26, 2026
@github-actions
Copy link
Contributor

Welcome, contributor! Thank you for your contribution to opentelemetry-collector-contrib.

Important reminders:

A maintainer will review your pull request soon. Thank you for helping make OpenTelemetry better!

@markobachvarovski markobachvarovski marked this pull request as draft January 26, 2026 20:42
@markobachvarovski markobachvarovski force-pushed the add-configurable-id-to-supervisor branch from eaeb54f to e2148de Compare January 26, 2026 21:45
@markobachvarovski markobachvarovski marked this pull request as ready for review January 26, 2026 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants