[filestatsreceiver] Rename filestats_darwin.go to filestats_bsd.go To Fix Build Tag Issues #45680
+27
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blewis12
force-pushed
the
fix-bsd-tag-issue-with-filestats-receiver
branch
from
0a854a7 to
5da2ebe
Compare
iblancasa
approved these changes
Jan 27, 2026
Contributor
Author
|
The telemetrygen action failed with a 502 error which seems to be a hiccup, if someone could re-run that? |
Contributor
|
/rerun |
axw
approved these changes
Jan 28, 2026
Contributor
Author
|
I'm not authorized to merge this PR - could someone else do that since it's approved? Let me know if there's a reason to hold off on it though |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This addresses #42645
Despite the bsd build tags being included in the source, they seem to not be respected because of the
_darwinfilename suffix. Renaming the suffix to_bsdseems to fix the issue, and the build tags are once again respectedLink to tracking issue
#42645
Testing
No testing, though this fix was tested in our pipelines that build the filestat receiver on multiple platforms (including FreeBSD) and these are now passing