[exporter/opensearch] Fix crash when sending_queue configured #45683
+86
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Welcome, contributor! Thank you for your contribution to opentelemetry-collector-contrib. Important reminders:
A maintainer will review your pull request soon. Thank you for helping make OpenTelemetry better! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #45016
Description
Fix OpenSearch exporter crash when sending_queue only configures batch
Problem
The OpenSearch exporter crashes with the error num_consumers must be positive when sending_queue is configured with only the batch subsection and omits num_consumers and queue_size.
Solution
Added an Unmarshal() method that applies default values when these fields are not explicitly set:
num_consumers = 10 queue_size = 1000This follows the same defaulting pattern already used by the Elasticsearch exporter.
Testing
Added test case sending_queue_with_batch in config_test.go
All existing tests pass
Verified with race detection