[extension/bearertokenauth] Fix: Bearertokenauth extension to handle HTTP header canonicalization when using a custom header. #45698
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…age the canonical header key to conform to golang http standards
…ect calls with http.StatusCreated (status code 201) as per the faro openAPI schema
… to collect calls with http.StatusCreated (status code 201) as per the faro openAPI schema" This reverts commit b9c331f.
Contributor
|
Welcome, contributor! Thank you for your contribution to opentelemetry-collector-contrib. Important reminders:
A maintainer will review your pull request soon. Thank you for helping make OpenTelemetry better! |
Contributor
|
Please add a test, add a changelog and mark ready to review again. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the authentication logic to use the CanonicalHeaderKey version of the input custom header string since the net/http standard lib automatically converts header keys to this canonical form.
Link to tracking issue
Fixes 45697
Testing
Running a docker compose with a local build.
Documentation
No documentation added yet. Not sure if this is required.