-
Notifications
You must be signed in to change notification settings - Fork 3.3k
[processor/redaction] Add HMAC support for GDPR compliance #45715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
syhan
wants to merge
5
commits into
open-telemetry:main
Choose a base branch
from
syhan:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+458
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Welcome, contributor! Thank you for your contribution to opentelemetry-collector-contrib. Important reminders:
A maintainer will review your pull request soon. Thank you for helping make OpenTelemetry better! |
iblancasa
reviewed
Jan 29, 2026
iblancasa
reviewed
Jan 29, 2026
iblancasa
reviewed
Jan 29, 2026
Contributor
iblancasa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but would like to see what other code owners think.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds HMAC (Hash-based Message Authentication Code) hash functions (
hmac-sha256andhmac-sha512) to the redaction processor, enabling GDPR-compliant pseudonymization of sensitive data such as IP addresses in telemetry data.Problem:
The current redaction processor supports simple hash functions (MD5, SHA1, SHA3), which are vulnerable to rainbow table attacks for low-entropy data like IP addresses. IPv4 has only ~4.3 billion possible values (2^32), making it feasible to pre-compute all possible hashes and reverse them. This violates GDPR Article 4(5) requirements for true pseudonymization.
Solution:
HMAC addresses this security gap by requiring a secret key, making it practically impossible to reverse-engineer original values without the key while maintaining consistency (same input + same key = same output) required for pattern analysis.
Changes:
HMACSHA256andHMACSHA512hash function types,HMACKeyconfiguration fieldhashStringHMAChelper functionUsage Example:
Link to tracking issue
N/A - This is a new feature addition for GDPR compliance. No existing issue tracking this enhancement.
Testing
Added 4 comprehensive unit tests covering:
All new tests and existing tests pass successfully:
Manual testing:
Documentation
Updated
processor/redactionprocessor/README.mdwith:hmac-sha256andhmac-sha512Key Benefits:
Security Considerations:
References: