Skip to content

[extension/awslogs_encoding] implement streaming contract for WAF logs#46223

Merged
atoulme merged 6 commits intoopen-telemetry:mainfrom
Kavindu-Dodan:feat/aws-logs-waf-logs
Mar 3, 2026
Merged

[extension/awslogs_encoding] implement streaming contract for WAF logs#46223
atoulme merged 6 commits intoopen-telemetry:mainfrom
Kavindu-Dodan:feat/aws-logs-waf-logs

Conversation

@Kavindu-Dodan
Copy link
Copy Markdown
Contributor

@Kavindu-Dodan Kavindu-Dodan commented Feb 19, 2026

Description

Based on contract introduced at #46211, this PR implements streaming for WAF logs.

WAF logs change is focused at commit titled streaming for WAF logs

Related - #46214

Testing

Unit tests and dedicated streaming tests

Documentation

Updated documentation on streaming contract

Copy link
Copy Markdown
Contributor

@axw axw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, modulo issues raised in #46211

@Kavindu-Dodan Kavindu-Dodan changed the title feat: implement streaming contract for WAF logs [extension/awslogs_encoding] implement streaming contract for WAF logs Feb 24, 2026
@atoulme
Copy link
Copy Markdown
Contributor

atoulme commented Feb 26, 2026

Please attend to the checks by running make tidylist and update to latest main.

Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co>
Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co>
@Kavindu-Dodan
Copy link
Copy Markdown
Contributor Author

@atoulme build failure is addressed and PR is ready to merge.

@constanca-m constanca-m added the ready to merge Code review completed; ready to merge by maintainers label Mar 2, 2026
Kavindu-Dodan and others added 2 commits March 2, 2026 09:49
Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co>
@atoulme atoulme removed the ready to merge Code review completed; ready to merge by maintainers label Mar 3, 2026
@atoulme
Copy link
Copy Markdown
Contributor

atoulme commented Mar 3, 2026

same please fix conflict

@Kavindu-Dodan
Copy link
Copy Markdown
Contributor Author

@atoulme conflicts are fixed and appreciate help with merging when you have time :)

@atoulme atoulme merged commit 4a85733 into open-telemetry:main Mar 3, 2026
191 checks passed
antonio-mazzini pushed a commit to antonio-mazzini/opentelemetry-collector-contrib that referenced this pull request Mar 5, 2026
open-telemetry#46223)

#### Description

Based on contract introduced at
open-telemetry#46211,
this PR implements streaming for WAF logs.

WAF logs change is focused at commit titled `streaming for WAF logs`

#### Testing

Unit tests and dedicated streaming tests 

#### Documentation

Updated documentation on streaming contract

---------

Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co>
avleentwilio pushed a commit to avleentwilio/opentelemetry-collector-contrib that referenced this pull request Apr 1, 2026
open-telemetry#46223)

#### Description

Based on contract introduced at
open-telemetry#46211,
this PR implements streaming for WAF logs.

WAF logs change is focused at commit titled `streaming for WAF logs`

#### Testing

Unit tests and dedicated streaming tests 

#### Documentation

Updated documentation on streaming contract

---------

Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants