[internal/core] migrate semconv from v1.12.0#46533

Merged

ChrsMark merged 23 commits intoopen-telemetry:mainfrom

paulojmdias:feat/45076

Mar 5, 2026

Member

paulojmdias commented Mar 1, 2026 •

edited

Loading

Description

Add feature gates to migrate deprecated semconv v1.12.0 attributes to their v1.38.0 equivalents in pkg/translator/zipkin and internal/coreinternal/goldendataset, following the semconv feature gates RFC.

Both gates default to disabled, preserving the existing behavior. Users can opt in to the migration at their own pace.

Zipkin translator (pkg.translator.zipkin.*):

net.host.ip -> network.local.address
net.peer.ip -> network.peer.address

goldendataset (internal.coreinternal.goldendataset.*):

net.host.ip -> network.local.address
net.peer.ip -> network.peer.address
http.host -> server.address
http.server_name -> server.address

Migration path:

Enable <component>.EmitV1NetworkConventions to start emitting both old and new keys (dual-emit transition)
Once user pipelines and backends are updated, also enable <component>.DontEmitV0NetworkConventions to stop emitting the deprecated v1.12.0 keys.

Initially, this was split into 2 PRs, but the #46534 is also a dependency for this one, so I checked out the code for this PR and closed that one.

Link to tracking issue

Fixes #45076 #45041

Testing

Tested locally without any error.

paulojmdias added 3 commits

March 1, 2026 17:19


          [internal/core] migrate semconv from v1.12.0

5e7e389

Signed-off-by: Paulo Dias <paulodias.gm@gmail.com>


          chore: fix component

d8901ca

Signed-off-by: Paulo Dias <paulodias.gm@gmail.com>


          chore: make gotidy

6fc1405

Signed-off-by: Paulo Dias <paulodias.gm@gmail.com>

paulojmdias mentioned this pull request

[ci] remove semconv 1.12.0 deepguard #46538

Draft


          [pkg/translator/zipkin] migrate semconv from v1.12.0

60e0735

Signed-off-by: Paulo Dias <paulodias.gm@gmail.com>

paulojmdias marked this pull request as ready for review

March 1, 2026 22:27

paulojmdias requested review from a team, MovieStoreGuy, andrzej-stencel and crobert-1 as code owners

March 1, 2026 22:27

github-actions bot assigned dmitryax

paulojmdias mentioned this pull request

[pkg/translator/zipkin] migrate semconv from v1.12.0 #46534

Closed

github-actions bot added receiver/zipkin pkg/translator/zipkin pkg/translator/jaeger internal/core labels

github-actions bot requested a review from frzifus

March 1, 2026 22:27

MovieStoreGuy approved these changes

View reviewed changes

frzifus approved these changes

View reviewed changes

paulojmdias added the ready to merge label

ChrsMark reviewed

View reviewed changes

Member

ChrsMark left a comment

Given that it's a breaking change on the schema, did we considered doing it following the https://github.com/open-telemetry/opentelemetry-collector/blob/main/docs/rfcs/semconv-feature-gates.md?

paulojmdias removed the ready to merge label

Member Author

paulojmdias commented Mar 2, 2026

Given that it's a breaking change on the schema, did we considered doing it following the https://github.com/open-telemetry/opentelemetry-collector/blob/main/docs/rfcs/semconv-feature-gates.md?

Not really, I was not aware of this RFC at all. I'll look into it.


          feat: move semconv updates behing feature gate

d7fe7ef

Signed-off-by: Paulo Dias <paulodias.gm@gmail.com>

Member Author

paulojmdias commented Mar 2, 2026

@ChrsMark Thank you, I added the changes behind feature gates in the following commit, PTAL.

@MovieStoreGuy @frzifus PTAL again, as I changed the behaviour to be behind a feature gate as the RFC asks to avoid being a breaking change.

If everything is ok, I'll create issues to move this feature gates to Alpha and Stable some versions later.

paulojmdias and others added 5 commits

March 2, 2026 11:00


          chore: make generate-chloggen-components

787a5ce

Signed-off-by: Paulo Dias <paulodias.gm@gmail.com>


          chore: update changelog

f94064c

Signed-off-by: Paulo Dias <paulodias.gm@gmail.com>


          chore: make gotidy

722b008

Signed-off-by: Paulo Dias <paulodias.gm@gmail.com>


          Merge branch 'main' into feat/45076

2b75c07


          Merge branch 'main' of github.com:paulojmdias/opentelemetry-collector…

6a69960

…-contrib into feat/45076

Signed-off-by: Paulo Dias <paulodias.gm@gmail.com>

paulojmdias added 2 commits

March 2, 2026 14:35


          Merge branch 'feat/45076' of github.com:paulojmdias/opentelemetry-col…

5b6df57

…lector-contrib into feat/45076

Signed-off-by: Paulo Dias <paulodias.gm@gmail.com>


          feat: add fg status handling

58707d9

Signed-off-by: Paulo Dias <paulodias.gm@gmail.com>

github-actions bot added the exporter/zipkin label

paulojmdias and others added 2 commits

March 2, 2026 17:10


          Merge branch 'main' of github.com:paulojmdias/opentelemetry-collector…

8240bff

…-contrib into feat/45076

Signed-off-by: Paulo Dias <paulodias.gm@gmail.com>


          Merge branch 'main' into feat/45076

9fd50e2

paulojmdias marked this pull request as draft

March 2, 2026 21:46

paulojmdias and others added 5 commits

March 2, 2026 22:09


          chore: move fg validation

faf8b9a

Signed-off-by: Paulo Dias <paulodias.gm@gmail.com>


          Merge branch 'feat/45076' of github.com:paulojmdias/opentelemetry-col…

2ced8d1

…lector-contrib into feat/45076

Signed-off-by: Paulo Dias <paulodias.gm@gmail.com>


          chore: remove 0

e7f6148


          chore: make gotidy

d04d35e

Signed-off-by: Paulo Dias <paulodias.gm@gmail.com>


          fix: variable shadowing

Signed-off-by: Paulo Dias <paulodias.gm@gmail.com>

paulojmdias marked this pull request as ready for review

March 2, 2026 23:03


          Merge branch 'main' into feat/45076

4a322f1

songy23 added the waiting-for-code-owners label

crobert-1 approved these changes

View reviewed changes

paulojmdias added 2 commits

March 4, 2026 09:33


          Merge branch 'main' into feat/45076

3f05afd


          Merge branch 'main' into feat/45076

d35ebc8

MovieStoreGuy approved these changes

View reviewed changes

Contributor

atoulme commented Mar 5, 2026

@ChrsMark please take another look


          Merge branch 'main' into feat/45076

e61a259

ChrsMark approved these changes

View reviewed changes

paulojmdias added the ready to merge label

ChrsMark merged commit 67adac4 into open-telemetry:main

208 checks passed

paulojmdias deleted the feat/45076 branch

March 5, 2026 16:30

This was referenced Mar 5, 2026

[internal/core] Promote semconv feature gates to Beta #46680

Open

[pkg/translator/zipkin] Promote semconv feature gates to Beta #46682

Open

antonio-mazzini pushed a commit to antonio-mazzini/opentelemetry-collector-contrib that referenced this pull request


          [internal/core] migrate semconv from v1.12.0 (open-telemetry#46533)

6106e05

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

Add feature gates to migrate deprecated semconv v1.12.0 attributes to
their v1.38.0 equivalents in pkg/translator/zipkin and
internal/coreinternal/goldendataset, following the [semconv feature
gates
RFC](https://github.com/open-telemetry/opentelemetry-collector/blob/main/docs/rfcs/semconv-feature-gates.md).

Both gates default to disabled, preserving the existing behavior. Users
can opt in to the migration at their own pace.

Zipkin translator (`pkg.translator.zipkin.*`):

  - `net.host.ip` -> `network.local.address`
  - `net.peer.ip` -> `network.peer.address`
 
goldendataset (`internal.coreinternal.goldendataset.*`):

  - `net.host.ip` -> `network.local.address`
  - `net.peer.ip` -> `network.peer.address`
  - `http.host` -> `server.address`
  - `http.server_name` -> `server.address`
  
Migration path:

Enable `<component>.EmitV1NetworkConventions` to start emitting both old
and new keys (dual-emit transition)
Once user pipelines and backends are updated, also enable
`<component>.DontEmitV0NetworkConventions` to stop emitting the
deprecated v1.12.0 keys.
  
Initially, this was split into 2 PRs, but the
open-telemetry#46534
is also a dependency for this one, so I checked out the code for this PR
and closed that one.

<!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. -->
#### Link to tracking issue
Fixes open-telemetry#45076 open-telemetry#45041

<!--Describe what testing was performed and which tests were added.-->
#### Testing

Tested locally without any error.

---------

Signed-off-by: Paulo Dias <paulodias.gm@gmail.com>

paulojmdias mentioned this pull request

[pkg/translator/zipkin] migrate semconv from v1.12.0 #45041

Closed

avleentwilio pushed a commit to avleentwilio/opentelemetry-collector-contrib that referenced this pull request


          [internal/core] migrate semconv from v1.12.0 (open-telemetry#46533)

9737fe7

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

Add feature gates to migrate deprecated semconv v1.12.0 attributes to
their v1.38.0 equivalents in pkg/translator/zipkin and
internal/coreinternal/goldendataset, following the [semconv feature
gates
RFC](https://github.com/open-telemetry/opentelemetry-collector/blob/main/docs/rfcs/semconv-feature-gates.md).

Both gates default to disabled, preserving the existing behavior. Users
can opt in to the migration at their own pace.

Zipkin translator (`pkg.translator.zipkin.*`):

  - `net.host.ip` -> `network.local.address`
  - `net.peer.ip` -> `network.peer.address`
 
goldendataset (`internal.coreinternal.goldendataset.*`):

  - `net.host.ip` -> `network.local.address`
  - `net.peer.ip` -> `network.peer.address`
  - `http.host` -> `server.address`
  - `http.server_name` -> `server.address`
  
Migration path:

Enable `<component>.EmitV1NetworkConventions` to start emitting both old
and new keys (dual-emit transition)
Once user pipelines and backends are updated, also enable
`<component>.DontEmitV0NetworkConventions` to stop emitting the
deprecated v1.12.0 keys.
  
Initially, this was split into 2 PRs, but the
open-telemetry#46534
is also a dependency for this one, so I checked out the code for this PR
and closed that one.

<!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. -->
#### Link to tracking issue
Fixes open-telemetry#45076 open-telemetry#45041

<!--Describe what testing was performed and which tests were added.-->
#### Testing

Tested locally without any error.

---------

Signed-off-by: Paulo Dias <paulodias.gm@gmail.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ChrsMark ChrsMark approved these changes

MovieStoreGuy MovieStoreGuy approved these changes

crobert-1 crobert-1 approved these changes

andrzej-stencel Awaiting requested review from andrzej-stencel andrzej-stencel is a code owner

+1 more reviewer

frzifus frzifus approved these changes

Labels

exporter/zipkin internal/core pkg/translator/jaeger pkg/translator/zipkin ready to merge receiver/zipkin waiting-for-code-owners