[processor/k8sattributes]: fix otel annotations attribute priority#46849
Open
davidspek wants to merge 1 commit intoopen-telemetry:mainfrom
Open
[processor/k8sattributes]: fix otel annotations attribute priority#46849davidspek wants to merge 1 commit intoopen-telemetry:mainfrom
davidspek wants to merge 1 commit intoopen-telemetry:mainfrom
Conversation
davidspek
requested review from
a team,
ChrsMark,
TylerHelmuth,
dmitryax and
fatsheep9146
as code owners
Contributor
|
Welcome, contributor! Thank you for your contribution to opentelemetry-collector-contrib. Important reminders:
A maintainer will review your pull request soon. Thank you for helping make OpenTelemetry better! |
davidspek
force-pushed
the
fix/k8s-attributes-otel-annotation
branch
2 times, most recently
from
20b1b15 to
eda5fa0
Compare
Signed-off-by: David van der Spek <david.vanderspek@flyrlabs.com>
davidspek
force-pushed
the
fix/k8s-attributes-otel-annotation
branch
from
eda5fa0 to
1b6d1cb
Compare
Member
|
/workflow-approve |
Member
|
Please add a changelog |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
According to the semconv, the
resource.opentelemetry.io/*pod annotations should have the highest priority for configuring theservice.namespace,service.name,service.versionandservice.instance.idattributes. However, in the current logic the values from the well-known labels will override the ones coming from theresource.opentelemetry.io/*pod annotations. This PR fixes this and includes unit tests to ensure the pod annotations will have the highest priority.Link to tracking issue
Fixes
Testing
Added unit tests to ensure the otel attributes have higher priority than the well-known labels.
Documentation