[receiver/hostmetrics] Enable re-aggregation for process and system scrapers#47221
Open
kruthiwusirika5 wants to merge 1 commit intoopen-telemetry:mainfrom
Open
Conversation
…rapers
Enable the re-aggregation feature for the two remaining hostmetrics
scrapers that were not yet covered.
process scraper:
- Add reaggregation_enabled: true
- Classify metric attributes (context_switch_type, direction,
paging_fault_type, state) as requirement_level: recommended
- Classify resource attributes by their role in process identity:
- required: process.pid, process.executable.name (uniquely identify
a process; cannot be dropped without losing process-level
granularity)
- recommended: process.command, process.executable.path,
process.owner (useful context, safe to drop for aggregation)
- opt_in: process.cgroup, process.command_line, process.parent_pid
(verbose or already disabled by default)
system scraper:
- Add reaggregation_enabled: true
- No metric or resource attributes require classification (the single
metric system.uptime has an empty attributes list)
Part of open-telemetry#46386.
kruthiwusirika5
requested review from
a team,
braydonk and
dmitryax
as code owners
Contributor
|
Welcome, contributor! Thank you for your contribution to opentelemetry-collector-contrib. Important reminders:
A maintainer will review your pull request soon. Thank you for helping make OpenTelemetry better! |
Member
|
/workflow-approve |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #46386.
Enables the re-aggregation feature for the two remaining
hostmetricsscrapers.process scraper
reaggregation_enabled: truerecommended(all four:context_switch_type,direction,paging_fault_type,state) — these are useful breakdowns but operators may want to aggregate them awayprocess.pidrequiredprocess.executable.namerequiredprocess.commandrecommendedprocess.executable.pathrecommendedprocess.ownerrecommendedprocess.command_lineopt_inprocess.parent_pidopt_inprocess.cgroupopt_inenabled: falsesystem scraper
reaggregation_enabled: truesystem.uptimehas an emptyattributes: []listValidation
go test ./internal/scraper/processscraper/... ./internal/scraper/systemscraper/...make generate