[extension/googlecloudlogentryencoding] fix protocol parsing for ALPN identifiers#47460
[extension/googlecloudlogentryencoding] fix protocol parsing for ALPN identifiers#47460tpilewicz wants to merge 1 commit intoopen-telemetry:mainfrom
Conversation
… identifiers Fixes open-telemetry#45214 Assisted-by: Claude Opus 4.6 Signed-off-by: tpilewicz <31728184+tpilewicz@users.noreply.github.com>
|
|
|
Welcome, contributor! Thank you for your contribution to opentelemetry-collector-contrib. Important reminders:
A maintainer will review your pull request soon. Thank you for helping make OpenTelemetry better! |
|
This PR #47621 would fix this issue. Would this work for you @tpilewicz ? Can we close this PR as a duplicate? |
|
@constanca-m works for me as long as we fix the encoding errors! Note however this slight difference:
Users might prefer to see the former in their telemetry, to get something consistent with the format emitted when |
can we discuss this on the PR #47621 so we get alignment there? Since we have two PRs trying to fix the same issue, we need to find a unified approach together |
|
Putting a comment there to start the discussion |
Description
Before: The googlecloudlogentryencoding extension cannot parse HTTP logs from Google Cloud load balancers because they provide ALPN identifiers for protocol (like
h2), while the extension expects theHTTP/2format.After: The extension is able to parse these logs and identify the
h2andh3ALPN identifiers as valid protocols.Assisted-by: Claude Opus 4.6
Link to tracking issue
Fixes #45214
Testing
Unit tests are added for the
h2andh3cases.