Skip to content

[extension/googlecloudlogentryencoding] fix protocol parsing for ALPN identifiers#47460

Closed
tpilewicz wants to merge 1 commit intoopen-telemetry:mainfrom
tpilewicz:45214-allow-h2-protocol
Closed

[extension/googlecloudlogentryencoding] fix protocol parsing for ALPN identifiers#47460
tpilewicz wants to merge 1 commit intoopen-telemetry:mainfrom
tpilewicz:45214-allow-h2-protocol

Conversation

@tpilewicz
Copy link
Copy Markdown

Description

Before: The googlecloudlogentryencoding extension cannot parse HTTP logs from Google Cloud load balancers because they provide ALPN identifiers for protocol (like h2), while the extension expects the HTTP/2 format.

After: The extension is able to parse these logs and identify the h2 and h3 ALPN identifiers as valid protocols.

Assisted-by: Claude Opus 4.6

Link to tracking issue

Fixes #45214

Testing

Unit tests are added for the h2 and h3 cases.

… identifiers

Fixes open-telemetry#45214

Assisted-by: Claude Opus 4.6
Signed-off-by: tpilewicz <31728184+tpilewicz@users.noreply.github.com>
@tpilewicz tpilewicz requested a review from a team as a code owner April 8, 2026 07:29
@tpilewicz tpilewicz requested a review from edmocosta April 8, 2026 07:29
@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla Bot commented Apr 8, 2026

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: tpilewicz / name: tpilewicz (8c39cf9)

@github-actions github-actions Bot added the first-time contributor PRs made by new contributors label Apr 8, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 8, 2026

Welcome, contributor! Thank you for your contribution to opentelemetry-collector-contrib.

Important reminders:

A maintainer will review your pull request soon. Thank you for helping make OpenTelemetry better!

@constanca-m
Copy link
Copy Markdown
Contributor

This PR #47621 would fix this issue. Would this work for you @tpilewicz ? Can we close this PR as a duplicate?

@tpilewicz
Copy link
Copy Markdown
Author

@constanca-m works for me as long as we fix the encoding errors! Note however this slight difference:

Users might prefer to see the former in their telemetry, to get something consistent with the format emitted when HTTP/1.1 is received.

@constanca-m
Copy link
Copy Markdown
Contributor

Users might prefer to see the former in their telemetry, to get something consistent with the format emitted when HTTP/1.1 is received.

can we discuss this on the PR #47621 so we get alignment there? Since we have two PRs trying to fix the same issue, we need to find a unified approach together

@tpilewicz
Copy link
Copy Markdown
Author

Putting a comment there to start the discussion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[extension/encoding/googlecloudlogentryencodingextension] Protocol validation does not allow h2

3 participants