receiver/httpcheck: stop double-emitting TLS cert-remaining data point#47831
Open
SAY-5 wants to merge 1 commit intoopen-telemetry:mainfrom
Open
receiver/httpcheck: stop double-emitting TLS cert-remaining data point#47831SAY-5 wants to merge 1 commit intoopen-telemetry:mainfrom
SAY-5 wants to merge 1 commit intoopen-telemetry:mainfrom
Conversation
RecordHttpcheckTLSCertRemainingDataPoint was called twice per scrape for every HTTPS endpoint: once inside the mux.Lock block before the timing metrics, and again a few lines lower after the timing metrics. The two blocks were byte-for-byte equivalent, so the receiver emitted duplicate httpcheck.tls.cert_remaining data points on every cycle. Remove the redundant pre-timing block. The post-timing block keeps the endpoint/issuer/commonName/sans labels unchanged. Fixes open-telemetry#47740. Signed-off-by: SAY-5 <SAY-5@users.noreply.github.com> Assisted-by: Claude Opus 4.7
Contributor
|
Welcome, contributor! Thank you for your contribution to opentelemetry-collector-contrib. Important reminders:
A maintainer will review your pull request soon. Thank you for helping make OpenTelemetry better! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
RecordHttpcheckTLSCertRemainingDataPointwas called twice per scrape for every HTTPS endpoint: once inside themux.Lockblock before the timing metrics, and again a few lines lower after the timing metrics. The two blocks were byte-for-byte equivalent, so the receiver emitted duplicatehttpcheck.tls.cert_remainingdata points on every cycle.Link to tracking issue: Fixes #47740
Testing:
go test ./receiver/httpcheckreceiver/... -count=1passes.Documentation: Added
.chloggen/47740-httpcheck-dedup-tls-cert-remaining.yamlunderbug_fix.Signed-off-by: SAY-5 SAY-5@users.noreply.github.com
Assisted-by: Claude Opus 4.7