Skip to content

[receiver/sqlserver] Add default service.name and service.namespace#48970

Open
akshays-19 wants to merge 2 commits into
open-telemetry:mainfrom
akshays-19:sqlserver-default-service-name
Open

[receiver/sqlserver] Add default service.name and service.namespace#48970
akshays-19 wants to merge 2 commits into
open-telemetry:mainfrom
akshays-19:sqlserver-default-service-name

Conversation

@akshays-19

@akshays-19 akshays-19 commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

This PR adds two resource attributes: service.name and service.namespace. Both default to enabled: false
When enabled:

  • service.name is set to unknown_service:microsoft.sql_server (per the
    OpenTelemetry semantic conventions for an unsp

Fixes #46176

The changes here replicate #46238 as the PR had become stale and closed.

  • I, a human, wrote this pull request description myself.

@akshays-19 akshays-19 requested review from a team and crobert-1 as code owners June 9, 2026 14:26
@github-actions github-actions Bot added receiver/sqlserver Run Windows Enable running windows test on a PR labels Jun 9, 2026
@github-actions github-actions Bot requested a review from sincejune June 9, 2026 14:26

@XSAM XSAM left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. You might need to check the failed tests

Comment thread receiver/sqlserverreceiver/scraper_test.go
Comment thread receiver/sqlserverreceiver/metadata.yaml Outdated
Comment thread receiver/sqlserverreceiver/scraper.go Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

receiver/sqlserver Run Windows Enable running windows test on a PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adding and defaulting service.* attributes as resource attributes

3 participants