[processor/tailsamplingprocessor] move spans during ingest instead of copying#48971
Draft
csmarchbanks wants to merge 1 commit into
Draft
[processor/tailsamplingprocessor] move spans during ingest instead of copying#48971csmarchbanks wants to merge 1 commit into
csmarchbanks wants to merge 1 commit into
Conversation
… copying Mark the processor as MutatesData=true and switch the per-span CopyTo to MoveTo when assembling per-trace ResourceSpans. The framework's fanoutconsumer handles fanout topologies via an upstream clone; in single-consumer pipelines the per-span deep copy becomes a pointer swap. Updates three concurrency/integrity tests that previously reused the input td across ConsumeTraces calls. Assisted-by: Claude Opus 4.7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Reduce the amount of allocations done by the tail sampling processor by using MoveTo when possible. This requires marking the processor as mutating data which will cause any fanout setups to still copy the data but shows ~10-15% improvement in allocations for users without a fanout.
Link to tracking issue
Testing
this change is transparent so all existing tests need to pass
Documentation
no documentation
Authorship