Updated dbname and service name for both query sample and top query log events#48995
Open
sjyothi54 wants to merge 8 commits into
Open
Updated dbname and service name for both query sample and top query log events#48995sjyothi54 wants to merge 8 commits into
sjyothi54 wants to merge 8 commits into
Conversation
1 task
crobert-1
reviewed
Jun 10, 2026
crobert-1
reviewed
Jun 11, 2026
| stringValue: ORCLPDB1 | ||
| - key: oracle.db.service | ||
| value: | ||
| stringValue: ORCLPDB1 |
Member
There was a problem hiding this comment.
Suggested change
| stringValue: ORCLPDB1 | |
| stringValue: ORCL |
Probably not a big deal, but it looks like this should just be the service, not the db name.
Comment on lines
+23
to
+24
| Requires Oracle 12c+ and `SELECT` on `V$CONTAINERS`. Both events are still | ||
| `enabled: false` by default. |
Member
There was a problem hiding this comment.
These should be removed unless they're different from before.
| On `db.server.query_sample` and `db.server.top_query` events, `db.namespace` | ||
| now reports the database name instead of the Oracle service | ||
| name. The service name moves to the new `oracle.db.service` attribute. | ||
| Existing dashboards or queries grouping by `db.namespace` on these events should be updated. |
Member
There was a problem hiding this comment.
I think we should remove this sentence, we don't need to recommend how to handle this outside the scope of the collector itself.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug in how the oracledbreceiver collecting db.namespace for query_sample
The Problem:
Previously, the code used the Oracle service_name (the network connection string) as the db.name. This was incorrect for modern multi-tenant (CDB/PDB) Oracle setups. If one database used 3 different connection services, the collector treated them as 3 completely separate databases, splitting up your performance data and cluttering dashboards.
The Fix:
Link to tracking issue
Fixes
#48996
Testing
Documentation
Updated documentation.md with the new db.namespace and db.servicename for top and query sample log events
Authorship